Only create samba user if not already existing #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check via pdbedit whether the samba user already exists and only call smbpasswd if it does not. This avoids reset of the password on every container restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to manage my user's passwords manually rather than put them in any configuration file in clear text. I can change the password via smbpasswd after container start. However, the password is reset/removed on every container restart, because smbpasswd is executed unconditionally if a config file is configured.
This PR introduces a check via pdbedit whether the samba user already exists and only calls smbpasswd if it does not.
As this changes the current behavior (and some people might want to keep closed-loop management of passwords via configuration), I could also add a configuration, either globally via env var or per user. Please let me know @crazy-max if you would consider this for merge but want it configurable.