fix: Bring Asterion's ability names in line with overhauled Makhleb #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahyangyi
force-pushed
the
oneliner/asterion-abilities
branch
2 times, most recently
from
5e6b020 to
9d3fe50
Compare
Asterion's current ability name, "Greater Servant of Makhleb", comes from Makhleb's old ability names before the 0.32 overhaul. Since the overhaul was mostly merging the lesser/greater pairs while leaving the actual mechanics untouched, I think we can keep the existing monster spells (along with icons and descriptions), but use the new ability titles. The other ability, "Major Destruction", is contrasted with another monster spell "Legendary Destruction". It is thus not changed in this PR.
ahyangyi
force-pushed
the
oneliner/asterion-abilities
branch
from
9d3fe50 to
c2063c5
Compare
|
BTW, please let me know if you think it's better to also rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asterion's current ability name, "Greater Servant of Makhleb", comes from Makhleb's old ability names before the 0.32 overhaul.
Since the overhaul was mostly merging the lesser/greater pairs while leaving the actual mechanics untouched, I think we can keep the existing monster spells (along with icons and descriptions), but use the new ability titles.
The other ability, "Major Destruction", is contrasted with another monster spell "Legendary Destruction". It is thus not changed in this PR.