feat: Mipmapping wherever available, rcfile option #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see folks test this on:
Before merge. |
Cgettys
force-pushed
the
opengl-modernization-04
branch
3 times, most recently
from
d918532 to
f7a021f
Compare
* Make MipmapOptions an enum class * Add a struct to encapsulate a bunch of options that always go together * Use MipmapOptions instead of an opaque bool * Add rcfile option to opt/in out of trying to mipmap, to override a weird heuristic we have for some images. * Support mipmapping if GL_ARB_framebuffer_object extension is available too (basically all HW) * Support mipmapping on OpenGL ES 2+ as well. * Simplify the LoadTexture code (even covering subtexture + offset case we don't exercise today) * Also avoid some pointless reallocations * Optimize a loop that could have been a memset The comment said it was making a full white glyph - it wasn't doing what it intended, and was doing so inefficiently. Now it is. * Also optimize the loop ordering in one of the font rendering functions to have better memory locality instead of skipping around.
Cgettys
force-pushed
the
opengl-modernization-04
branch
from
f7a021f to
0754e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment said it was making a full white glyph - it wasn't doing what it intended, and was doing so inefficiently. Now it is.