Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some warnings produced by header_build_tests #4211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: some warnings produced by header_build_tests #4211

wants to merge 1 commit into from

Conversation

Cgettys
Copy link
Contributor

@Cgettys Cgettys commented Jan 6, 2025 •
edited
Loading

  • Add missing include to conduct-type.h to ensure it is self-contained (e.g. not depending on other headers happening to include tag-version.h before including it)
  • Remove unnecessary semicolon.
  • Add missing cstdint includes

@Cgettys
fix: some warnings produced by header_build_tests
aff38b1 
* Add missing include to conduct-type.h to ensure it is self-contained (e.g. not depending on other headers happening to include tag-version.h before including it)
* Remove unnecessary semicolon.
* Add missing cstdint includes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Cgettys