Let the user look at more "nogen" items in the help menu. #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2024 19:49
Replace the "nogen" tag with a "deleted" one for "TAG_MAJOR_VERSION = 34" sections of art-data.txt. Both tags mean the item isn't created in the normal way. The "deleted" tag alone stops the help menu from giving details of the item. Remove the code in extant_unrandart_by_exact_name() which let some of the nogen items be looked up.
Add the DELETED flag to the other place where it is needed for the script to add it to art-data.h.
|
Very nice, less places to update seems sane to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the "nogen" tag with a "deleted" one for "TAG_MAJOR_VERSION = 34" sections of art-data.txt. Both tags mean the item isn't created in the normal way. The "deleted" tag alone stops the help menu from giving details of the item.
Remove the code in extant_unrandart_by_exact_name() which let some (but not all) of the nogen items be looked up.
My hope here is that, if the data is all in art-data.txt, it's more likely to be updated correctly than it would be with two lists in completely different bits of code.
For what it's worth, the artefacts which have nogen but weren't on the list are:
faerie dragon scales (created with the Enchantress)
dreamdust necklace (created by using the dreamshard necklace)
Axe of Woe (Arena of Blood)
amulet of invisibility (Fedhas' Mad Dash)
scarf of invisibility (Fedhas' Mad Dash)