dcoraboeuf#285 Unit test for the securization of some services (not w…

…orking yet - the advisor is not applied on all eligible beans)
cpf · Nov 29, 2013 · e5e8f21 · e5e8f21
1 parent adb7698
commit e5e8f21
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 3 deletions.
diff --git a/ontrack-backend/src/test/java/net/ontrack/backend/AccountServiceTest.java b/ontrack-backend/src/test/java/net/ontrack/backend/AccountServiceTest.java
@@ -1,11 +1,13 @@
 package net.ontrack.backend;
 
 import net.ontrack.core.model.*;
+import net.ontrack.core.security.GlobalFunction;
 import net.ontrack.core.security.SecurityRoles;
 import net.ontrack.core.security.SecurityUtils;
 import net.ontrack.service.AccountService;
 import org.junit.Test;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.security.access.AccessDeniedException;
 
 import java.util.concurrent.Callable;
 
@@ -15,7 +17,6 @@ public class AccountServiceTest extends AbstractValidationTest {
 
     @Autowired
     private AccountService accountService;
-
     @Autowired
     private SecurityUtils securityUtils;
 
@@ -42,6 +43,74 @@ public void authenticate_wrong_password() {
         assertNull(account);
     }
 
+    @Test
+    public void createAccount_admin_ok() throws Exception {
+        final String name = uid("A");
+        Account account = asAdmin().call(new Callable<Account>() {
+            @Override
+            public Account call() throws Exception {
+                return accountService.getAccount(
+                        accountService.createAccount(
+                                new AccountCreationForm(
+                                        name,
+                                        "Account " + name,
+                                        name + "@test.com",
+                                        SecurityRoles.USER,
+                                        "builtin",
+                                        "***",
+                                        "***"
+                                )
+                        ).getValue());
+            }
+        });
+        assertEquals(name, account.getName());
+    }
+
+    @Test
+    public void createAccount_user_granted_ok() throws Exception {
+        final String name = uid("A");
+        Account account = asUser().withGlobalFn(GlobalFunction.ACCOUNT_MANAGEMENT).call(new Callable<Account>() {
+            @Override
+            public Account call() throws Exception {
+                return accountService.getAccount(
+                        accountService.createAccount(
+                                new AccountCreationForm(
+                                        name,
+                                        "Account " + name,
+                                        name + "@test.com",
+                                        SecurityRoles.USER,
+                                        "builtin",
+                                        "***",
+                                        "***"
+                                )
+                        ).getValue());
+            }
+        });
+        assertEquals(name, account.getName());
+    }
+
+    @Test(expected = AccessDeniedException.class)
+    public void createAccount_user_denied() throws Exception {
+        final String name = uid("A");
+        asUser().call(new Callable<Account>() {
+            @Override
+            public Account call() throws Exception {
+                return accountService.getAccount(
+                        accountService.createAccount(
+                                new AccountCreationForm(
+                                        name,
+                                        "Account " + name,
+                                        name + "@test.com",
+                                        SecurityRoles.USER,
+                                        "builtin",
+                                        "***",
+                                        "***"
+                                )
+                        ).getValue());
+            }
+        });
+    }
+
     @Test
     public void change_email_ok() throws Exception {
         securityUtils.asAdmin(new Callable<Void>() {

diff --git a/ontrack-backend/src/test/resources/log4j.properties b/ontrack-backend/src/test/resources/log4j.properties
@@ -2,8 +2,8 @@
 
 log4j.rootLogger=error, Console
 
-#log4j.logger.org.springframework=info
-#log4j.logger.net.ontrack.backend.config.BackendProtectPointcutPostProcessor=debug
+log4j.logger.org.springframework.security=debug
+log4j.logger.net.ontrack.backend.config.BackendProtectPointcutPostProcessor=debug
 #log4j.logger.net.ontrack=debug
 
 log4j.appender.Console=org.apache.log4j.ConsoleAppender