Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update halfplane-intersection.md #1367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Harsh-Mathur-1503
Copy link
Contributor

Changes in this commit -

  1. Bounding Box Adjustment: In your initial algorithm (previous code), where you define a static bounding box using Point(inf, inf) and Point(-inf, -inf), you need to replace this with a dynamically calculated bounding box based on the actual input points.
  2. eps and inf Updates: You should update eps and inf in the previous code to values that suit your input size better, handling small floating-point inaccuracies more gracefully.

Changes in this commit - 
1. Bounding Box Adjustment: In your initial algorithm (previous code), where you define a static bounding box using Point(inf, inf) and Point(-inf, -inf), you need to replace this with a dynamically calculated bounding box based on the actual input points.
2. eps and inf Updates: You should update eps and inf in the previous code to values that suit your input size better, handling small floating-point inaccuracies more gracefully.
@adamant-pwn
Copy link
Member

Hi, thanks for the pull request! Could you please reply to these questions?

  1. Was this PR generated with the help of AI?
  2. Did you check whether your PR actually fixes the issue when run on the example from Half-plane intersection #1332?
  3. Why exactly the large bounding box causes a wrong result, and why choosing it dynamically would help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants