Fix code scanning alert no. 4: Incomplete regular expression for host…

…names (#726) * Fix code scanning alert no. 4: Incomplete regular expression for hostnames Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Fix security issues in regex --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
coveooss · Nov 27, 2024 · c07f64b · c07f64b
1 parent f44b2b5
commit c07f64b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/awshelper/s3.go b/awshelper/s3.go
@@ -61,10 +61,10 @@ func formatS3Path(bucket, region string, parts ...string) string {
 func GetBucketObjectInfoFromURL(url string) (*BucketInfo, error) {
 	if s3Patterns == nil {
 		s3Patterns = []*regexp.Regexp{
-			regexp.MustCompile(`^https?://(?P<bucket>[^/\.]+?).s3.amazonaws.com(?:/(?P<key>.*))?$`),
-			regexp.MustCompile(`^https?://(?P<bucket>[^/\.]+?).s3-(?P<region>.*?).amazonaws.com(?:/(?P<key>.*))?$`),
-			regexp.MustCompile(`^(s3::)?https?://s3.amazonaws.com/(?P<bucket>[^/\.]+?)(?:/(?P<key>.*))?$`),
-			regexp.MustCompile(`^(s3::)?https?://s3-(?P<region>.*?).amazonaws.com/(?P<bucket>[^/\.]+?)(?:/(?P<key>.*))?$`),
+			regexp.MustCompile(`^https?://(?P<bucket>[^/\.]+?)\.s3\.amazonaws\.com(?:/(?P<key>.*))?$`),
+			regexp.MustCompile(`^https?://(?P<bucket>[^/\.]+?)\.s3-(?P<region>.*?)\.amazonaws\.com(?:/(?P<key>.*))?$`),
+			regexp.MustCompile(`^(s3::)?https?://s3\.amazonaws\.com/(?P<bucket>[^/\.]+?)(?:/(?P<key>.*))?$`),
+			regexp.MustCompile(`^(s3::)?https?://s3-(?P<region>.*?)\.amazonaws\.com/(?P<bucket>[^/\.]+?)(?:/(?P<key>.*))?$`),
 		}
 	}