Fix a problem with exit code 2. If there is an exit code of 1, the fi…

…nal result must be 1 because it indicates that there is an error, The priority oder is 1, 2, 0.
coveooss · Apr 28, 2017 · 1017989 · 1017989
1 parent 72d4a8d
commit 1017989
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/configstack/running_module.go b/configstack/running_module.go
@@ -257,7 +257,9 @@ func (this MultiError) ExitStatus() (int, error) {
 	for i := range this.Errors {
 		if code, err := shell.GetExitCode(this.Errors[i]); err != nil {
 			return -1, this
-		} else if code > exitCode {
+		} else if code == 1 || code == 2 && exitCode == 0 {
+			// The exit code 1 is more significant that the exit code 2 because it represents an error
+			// while 2 represent a warning.
 			exitCode = code
 		}
 	}

diff --git a/configstack/stack_plan.go b/configstack/stack_plan.go
@@ -44,7 +44,7 @@ func (stack *Stack) planWithSummary(terragruntOptions *options.TerragruntOptions
 	return err
 }
 
-// Returns the handler and the list of results
+// Returns the handler that will be executed after each completion of `terraform plan`
 func getResultHandler(detailedExitCode bool, results *[]moduleResult, mutex *sync.Mutex) ModuleHandler {
 	return func(module TerraformModule, output string, err error) error {
 		inspectPlanResult(module, output)