You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should try to crosscheck with different approaches the External Compton radiation:
crosscheck against the literature;
crosscheck against another code;
crosscheck against back-of-the-envelope calculation.
Each of the tick box will be marked once the crosscheck is obtained.
After all of them are marked we will close the issue, and be sure that the EC computation is reliable.
The text was updated successfully, but these errors were encountered:
I think the introduction of the test suite addresses the pending checks in this issue.
We have now the following automatic crosschecks for the external Compton radiation:
- crosscheck for EC on Disk against the literature (Finke 2016)
- crosscheck for EC on Broad Line Region against the literature (Finke 2016)
- crosscheck for EC on Dust Torus against the literature (Finke 2016)
As for the crosschecks against back-of-the-envelope calculation I have implemented two test functions that check, in the limit of large distances, if the EC on the BLR (or DT) tends to the one of a point-like source approximating them.
The crosschecks against another code are a bit difficult since Jetset uses different geometries for the targets.
Nonetheless I am confident the External Compton calculations in agnpy are reliable.
We should try to crosscheck with different approaches the External Compton radiation:
Each of the tick box will be marked once the crosscheck is obtained.
After all of them are marked we will close the issue, and be sure that the EC computation is reliable.
The text was updated successfully, but these errors were encountered: