This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
V1.7.1 patchset #152
Closed
V1.7.1 patchset #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But under a new path - `/metrics/cadvisor`. This ensures a secure port still exists for metrics while getting the benefit of separating out container metrics from the kubelet's metrics.
squat
changed the title
|
FWIW, I did the same cherry-picking of this commit onto 1.7.1 in a fork of mine, and 1/2 of the controllers would not start, as well as 1 out of the 2 schedulers wouldn't either. I didn't go much further than that |
|
I tested this hyperkube as well. This patch results in a broken cluster and the masters do not come up. This is not going so fix kubernetes#48483 on 1.7.1 alone. Clearly, this patch depends on something in kubernetes/kubernetes@v1.7.0...f5f9893, which is huge. We will need to wait for 1.7.2 upstream or fix this in prometheus. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore cAdvisor prometheus metrics to the main port
cherrry-pick kubernetes#49079 into 1.7.1 patchset and merge into 1.7.1 branch. cc @aaronlevy @s-urbaniak @sym3tri