This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
doc: op guide for install, uninstall etcd operator #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once kubernetes supports deployment hook (kubernetes/kubernetes#14512), we can make use of that as well. |
xiang90
reviewed
Mar 3, 2017
README.md
Outdated
| @@ -50,6 +50,11 @@ NAME DESCRIPTION VERSION(S) | |||
| cluster.etcd.coreos.com Managed etcd clusters v1beta1 | |||
| ``` | |||
|
|
|||
| When deleting etcd operator deployment, delete its leader election endpoint as well: | |||
There was a problem hiding this comment.
i do not think this is a good place. it is not discoverable.
Probably it is time for us to create the initial op-guide with our first section:
- uninstall etcd operator
we mention how to delete the operator, how to remove the endpoint, and tell users they also need to manually remove all etcd clusters managed by etcd operator manually (or remove all the TPRs before delete the operator.).
hongchaodeng
changed the title
|
fixed |
xiang90
reviewed
Mar 3, 2017
doc/user/op_guide.md
Outdated
| $ kubectl delete endpoints etcd-operator | ||
| ``` | ||
|
|
||
| Note that the etcd clusters managed by etcd operator will **NOT** be deleted if the operator fails or is uninstalled. |
xiang90
reviewed
Mar 3, 2017
doc/user/op_guide.md
Outdated
| ``` | ||
|
|
||
| Note that the etcd clusters managed by etcd operator will **NOT** be deleted if the operator fails or is uninstalled. | ||
| This is an intentional design to prevent accidental operator failure from killing all the etcd clusters. |
There was a problem hiding this comment.
move this to the top under uninstall.
|
fixed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #735
[skip ci]