-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: migration from kube-dns #1167
Comments
Yes, that's what I think. |
How will this work?
or eat a manifest and write a new one? |
Ack, but not everyone will use kubeadm. I wonder if we should add a little helper inside coredns (but icky) and @johnbelamaric mentioned that at some point both configs (kube-dns config map + Corefile) must potentially be merged. |
The Corefile would need to be constructed based on kube-dns ConfigMap (which is currently blank in a default deployment) and Deployment command line args for kube-dns, and dnsmasq-nanny, (and possibly sidecar). Seems to make most sense to do this at deployment time - i.e. extending the existing deployment scripts in coredns/deployment. Whatever is done would ideally be gracefully reused by A possible flow would be to ...
@johnbelamaric: What is the "merge kube-dns config map + Corefile" case? |
Something we never want to do! My point is that since a Corefile could be arbitrarily complex with all sorts of stuff in it, we can't deterministically merge the "kube-dns config" into an arbitrary Corefile. Instead, I think we take our default K8s Corefile, and we have a way to write that out using data from the kube-dns configuration. This would create a functionally equivalent deployment of CoreDNS for a given kube-dns deployment. |
I don't think something inside makes sense. I think in the deployment repo and hopefully re-usable in kubeadmin is what we want. |
See: kubernetes/community#1100 (comment)
How should we support this? One-time converter of the kube-dns config?
The text was updated successfully, but these errors were encountered: