Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: migration from kube-dns #1167

Closed
miekg opened this issue Oct 23, 2017 · 7 comments
Closed

core: migration from kube-dns #1167

miekg opened this issue Oct 23, 2017 · 7 comments

Comments

@miekg
Copy link
Member

miekg commented Oct 23, 2017

See: kubernetes/community#1100 (comment)

How should we support this? One-time converter of the kube-dns config?

@johnbelamaric
Copy link
Member

Yes, that's what I think.

@miekg
Copy link
Member Author

miekg commented Oct 24, 2017

How will this work?

  • Parse the config map
  • Write Corefile
  • Let CoreDNS start up?

or eat a manifest and write a new one?

@chrisohaver
Copy link
Member

@miekg
Copy link
Member Author

miekg commented Oct 24, 2017

Ack, but not everyone will use kubeadm. I wonder if we should add a little helper inside coredns (but icky) and @johnbelamaric mentioned that at some point both configs (kube-dns config map + Corefile) must potentially be merged.

@chrisohaver
Copy link
Member

The Corefile would need to be constructed based on kube-dns ConfigMap (which is currently blank in a default deployment) and Deployment command line args for kube-dns, and dnsmasq-nanny, (and possibly sidecar).

Seems to make most sense to do this at deployment time - i.e. extending the existing deployment scripts in coredns/deployment. Whatever is done would ideally be gracefully reused by kubeadm upgrade without too much duplication or refactoring.

A possible flow would be to ...

  • Create yaml manifest of the existing kube-dns ConfigMap and Deployment.
  • Parse kube-dns manifest and create CoreDNS manifest

@johnbelamaric: What is the "merge kube-dns config map + Corefile" case?

@johnbelamaric
Copy link
Member

@johnbelamaric: What is the "merge kube-dns config map + Corefile" case?

Something we never want to do! My point is that since a Corefile could be arbitrarily complex with all sorts of stuff in it, we can't deterministically merge the "kube-dns config" into an arbitrary Corefile. Instead, I think we take our default K8s Corefile, and we have a way to write that out using data from the kube-dns configuration. This would create a functionally equivalent deployment of CoreDNS for a given kube-dns deployment.

@johnbelamaric
Copy link
Member

I don't think something inside makes sense. I think in the deployment repo and hopefully re-usable in kubeadmin is what we want.

@miekg miekg closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants