[persistent collections] based on PR-866 #1261
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoolekom
suggested changes
Dec 26, 2024
| return fmt.Errorf("initcol: collection %s is not valid", col) | ||
| } | ||
| // we validate if this is a persistent collection | ||
| persistent := []string{"USER", "SESSION", "IP", "RESOURCE", "GLOBAL"} |
There was a problem hiding this comment.
Do we really need to restrict arbitrary collection creation?
| @@ -76,8 +78,10 @@ func (a *setvarFn) Init(_ plugintypes.RuleMetadata, data string) error { | |||
| colKey, colVal, colOk := strings.Cut(key, ".") | |||
| // Right not it only makes sense to allow setting TX | |||
| // key is also required | |||
| if strings.ToUpper(colKey) != "TX" { | |||
| return errors.New("invalid arguments, expected collection TX") | |||
| available := []string{"TX", "USER", "GLOBAL", "RESOURCE", "SESSION", "IP"} | |||
| ) | ||
|
|
||
| // defaultEngine | ||
| // defaultEngine is just a sample and it shouldn't be used in production. |
There was a problem hiding this comment.
Shouldn't we use the third-party library then?
| switch v := res.(type) { | ||
| case string: | ||
| return v, nil | ||
| case int: |
There was a problem hiding this comment.
Why do we even store it as int if we only set a value of type string?
| @@ -116,4 +116,10 @@ type TransactionVariables interface { | |||
| ArgsGetNames() collection.Collection | |||
| ArgsPostNames() collection.Collection | |||
| MultipartStrictError() collection.Single | |||
| // TODO(v4: Add these) | |||
There was a problem hiding this comment.
I suppose we should add them in this PR.
| @@ -0,0 +1,50 @@ | |||
| // Copyright 2023 Juan Pablo Tosso and the OWASP Coraza contributors | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 Juan Pablo Tosso and the OWASP Coraza contributors | |
| // Copyright 2024 Juan Pablo Tosso and the OWASP Coraza contributors |
Maybe even 2025.
| Sessionid | ||
| // Userid is not supported | ||
| // Userid is a persistent collection of user ids |
There was a problem hiding this comment.
It's simply wrong. Could you add comments based on the official documentation?
|
Great job here. There is a PR for the close implementation #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the PR-866 of the original repository.
It is related to the issue-1227.
Persistence collections
Thanks for your contribution ❤️