fix: add empty glob error when no files match #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantony
force-pushed
the
empty_glob_error
branch
from
ca5863e to
cfcf29e
Compare
fzipi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 168 168
Lines 9762 9765 +3
=======================================
+ Hits 7974 7977 +3
Misses 1537 1537
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Just to confirm, what is the behavior of modsec on this? |
I think this is the exact same behavior as the There could be a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1250.
What
This PR adds an "empty glob" error when trying to include files using a glob pattern, but the pattern does not match any file.
Why
If a user specifies a config file with
Include rules./*.conf, the intent is that a number of files will be parsed (at least 1 😅).If for some reason the glob pattern does not match any file, we should return an error so that the user realizes there is a problem with the configuration.
The user can then fix the glob pattern (or remove it if not needed), instead of assuming that the expected configuration files have been loaded.
Checklist