Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): do not skip commit types #410

Closed
wants to merge 1 commit into from

Conversation

Visya
Copy link

@Visya Visya commented Feb 13, 2019

Before most commit types were skipped and not written into the changelog. This change allows all commit types be part of the changelog.

This was discussed in the issue #317, but no changes were made.

Before most commit types were skipped and not written into the changelog. This change allows all commit types be part of the changelog.

Relates to conventional-changelog#317
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.107% when pulling 917d66b on Visya:patch-1 into d3c2432 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.107% when pulling 917d66b on Visya:patch-1 into d3c2432 on conventional-changelog:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.107% when pulling 917d66b on Visya:patch-1 into d3c2432 on conventional-changelog:master.

@hutson
Copy link
Contributor

hutson commented Feb 13, 2019

@Visya looking through Angular's changelog I don't see CI, Docs, or other commit types published. Does this change break how Angular currently generates their changelog?

cc @damianopetrungaro I believe this need is completely legitimate, but maybe not for the Angular configuration. What are your thoughts on how we can meet this need?

@hutson hutson self-requested a review February 13, 2019 16:24
@hutson hutson added enhancement A change to a project's repository that adds new behavior for downstream consumers. suggestion Proposal for a change to the project where consensus may be needed. labels Feb 13, 2019
@Visya
Copy link
Author

Visya commented Feb 22, 2019

Hi @hutson

You're right, Angular doesn't include anything except feat, fix and revert in their changelog unless it's a breaking change (angular/angular#5672).

My reasoning was that it's nice to see all changes associated with the release, but on the other hand it can be seen as redundant for the user to see changes in the changelog that do not impact functionality. Maybe, a way to go would be to add this as a configuration option?

@JeffBeltran
Copy link

JeffBeltran commented Feb 26, 2019

wanted to chime in that i would love a "config" option that allows us to override the defaults. While i don't have the bandwidth to manage a PR right now if this seems a viable route i'll look into it

@stevemao
Copy link
Member

I don't think we should change angular config. We can create a new config.

@myii
Copy link

myii commented Feb 27, 2019

@Visya Thanks for this. We've been using this fix in saltstack-formulas/template-formula/release.config.js and it is working perfectly.

@hutson
Copy link
Contributor

hutson commented Mar 18, 2019

I feel the answer right now is to leave the angular preset unmodified, and encourage anyone wanting a slightly different output to create a fork of the angular preset with their changes.

Long-term, @bcoe is looking at supporting preset configuration in #421. A change that will hopefully meet your needs @Visya

@bcoe
Copy link
Member

bcoe commented Mar 18, 2019

@hutson I agree, I'm hoping that the conventional-changelog-conventionalcommits preset will create a good foundation for an easier to config preset that adheres explicitly to conventionalcommits.org.

@stevemao
Copy link
Member

Closing in favour of #421

@stevemao stevemao closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change to a project's repository that adds new behavior for downstream consumers. suggestion Proposal for a change to the project where consensus may be needed.
Development

Successfully merging this pull request may close these issues.

7 participants