-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): do not skip commit types #410
Conversation
Before most commit types were skipped and not written into the changelog. This change allows all commit types be part of the changelog. Relates to conventional-changelog#317
1 similar comment
@Visya looking through Angular's changelog I don't see CI, Docs, or other commit types published. Does this change break how Angular currently generates their changelog? cc @damianopetrungaro I believe this need is completely legitimate, but maybe not for the Angular configuration. What are your thoughts on how we can meet this need? |
Hi @hutson You're right, Angular doesn't include anything except My reasoning was that it's nice to see all changes associated with the release, but on the other hand it can be seen as redundant for the user to see changes in the changelog that do not impact functionality. Maybe, a way to go would be to add this as a configuration option? |
wanted to chime in that i would love a "config" option that allows us to override the defaults. While i don't have the bandwidth to manage a PR right now if this seems a viable route i'll look into it |
I don't think we should change angular config. We can create a new config. |
@Visya Thanks for this. We've been using this fix in saltstack-formulas/template-formula/release.config.js and it is working perfectly. |
I feel the answer right now is to leave the Long-term, @bcoe is looking at supporting preset configuration in #421. A change that will hopefully meet your needs @Visya |
@hutson I agree, I'm hoping that the |
Closing in favour of #421 |
Before most commit types were skipped and not written into the changelog. This change allows all commit types be part of the changelog.
This was discussed in the issue #317, but no changes were made.