Support RHEL hosts by creating containers based on UBI #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subsequent commit will add support for toolbox containers of operating system distributions that aren't Fedora. That will require a similar function that resolves a short image name to a fully qualified one, but by iterating through a list of supported images instead of using the image's RepoTags. containers#667
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 12, 2021
This shouldn't have any user-visible effect. However, it parametrizes various code paths that were currently hard-coded to represent Fedora. Subsequent commits will build upon this to support toolbox containers of operating system distributions that aren't Fedora. A map of supported operating system distributions has been introduced that lists out the necessary bits of metadata needed to work with them. In the future, it should just be a matter of adding new entries to this map to add support for distributions that aren't Fedora. containers#667
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 12, 2021
This is meant to allow the user to create toolbox containers of operating system distributions that are different from that of the host and isn't Fedora. containers#667
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 12, 2021
debarshiray
force-pushed
the
wip/rishi/ubi-staging
branch
from
39c26dd to
ae74d49
Compare
|
Build succeeded.
|
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 12, 2021
Fedora's /etc/bashrc sets the PROMPT_COMMAND environment variable to __vte_prompt_command when running inside a VteTerminal. This becomes a problem if the __vte_prompt_command shell function is missing because /etc/profile.d/vte.sh itself is absent [1], which is the case with the Red Hat Universal Base Image. This tricks the code in /etc/bashrc into not doing that. [1] https://pagure.io/setup/pull-request/23 containers#667
debarshiray
pushed a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 12, 2021
debarshiray
force-pushed
the
wip/rishi/ubi-staging
branch
from
ae74d49 to
a7e633d
Compare
This shouldn't have any user-visible effect. However, it parametrizes various code paths that were currently hard-coded to represent Fedora. Subsequent commits will build upon this to support toolbox containers of operating system distributions that aren't Fedora. A map of supported operating system distributions has been introduced that lists out the necessary bits of metadata needed to work with them. In the future, it should just be a matter of adding new entries to this map to add support for distributions that aren't Fedora. containers#667
This is meant to allow the user to create toolbox containers of operating system distributions that are different from that of the host and isn't Fedora. containers#667
Fedora's /etc/bashrc sets the PROMPT_COMMAND environment variable to __vte_prompt_command when running inside a VteTerminal. This becomes a problem if the __vte_prompt_command shell function is missing because /etc/profile.d/vte.sh itself is absent [1], which is the case with the Red Hat Universal Base Image. This tricks the code in /etc/bashrc into not doing that. [1] https://pagure.io/setup/pull-request/23 containers#667
debarshiray
force-pushed
the
wip/rishi/ubi-staging
branch
from
a7e633d to
21d25f8
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #658
It splits up the commits a bit, contains some fix-ups, but most importantly skips some parts of the container & image tracking backend to side-step issues like the one caused by the use of
latesttags. We can introduce the rest of the new backend later once we have solved all those issues.