Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove github.com/opencontainers/runc dependency #9114

Merged
merged 1 commit into from
Sep 27, 2023
Merged

remove github.com/opencontainers/runc dependency #9114

merged 1 commit into from
Sep 27, 2023

Conversation

thaJeztah
Copy link
Member

remove github.com/opencontainers/runc dependency

This migrates uses of github.com/opencontainers/runc/libcontainer/user to the new github.com/moby/sys/user module, which was extracted from runc at commit opencontainers/runc@a3a0ec48c464fe6458d2ba067f6707c027e5384e.

This is the initial release of the module, which is a straight copy, but some changes may be made in the next release (such as fixing camel-casing in some fields and functions (Uid -> UID).

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@AkihiroSuda
Copy link
Member

Still draft?

@thaJeztah
Copy link
Member Author

I think it's fine to merge, but also considering if we'd want those nits to be addressed before doing so; any preferences for "this PR" or "follow-up"? opencontainers/runc#4017 (comment)

Thanks! I'll also have a look at fixing the CameCase nits in moby/sys (for a v0.2.0, or whatever version it will be); for this one I wanted it to be a clean "move"

@thaJeztah thaJeztah mentioned this pull request Sep 7, 2023
Merged
2 tasks
@dmcgowan
Copy link
Member

I think it's fine to merge, but also considering if we'd want those nits to be addressed before doing so; any preferences for "this PR" or "follow-up"?

Not a big deal to just get this in as is then if a later version changes the casing, update then.

@thaJeztah
remove github.com/opencontainers/runc dependency
4b1bb12 
This migrates uses of github.com/opencontainers/runc/libcontainer/user
to the new github.com/moby/sys/user module, which was extracted from
runc at commit [opencontainers/runc@a3a0ec4].

This is the initial release of the module, which is a straight copy, but
some changes may be made in the next release (such as fixing camel-casing
in some fields and functions (Uid -> UID).

[opencontainers/runc@a3a0ec4]: opencontainers/runc@a3a0ec4

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ok, rebased; let me move it out of draft

@thaJeztah thaJeztah marked this pull request as ready for review September 27, 2023 15:35
@AkihiroSuda AkihiroSuda merged commit 719fa3d into containerd:main Sep 27, 2023
@thaJeztah thaJeztah deleted the remove_libcontainer branch September 27, 2023 19:44
This was referenced Oct 24, 2023
Merged
Merged
This was referenced Jan 5, 2024
Merged
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @k8s-ci-robot @AkihiroSuda @dmcgowan @estesp