Add optional existing serving certs secret #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Mikkel Kroman <mk@maero.dk>
Signed-off-by: Mikkel Kroman <mk@maero.dk>
mkroman
force-pushed
the
existing-serving-cert
branch
from
9bb405d to
b634c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it optional whether the chart should create the serving cert secret or not.
The default behavior of generating a certificate is unchanged.
The chart does not currently work with GitOps delivery tools like Argo CD since a random cert is generated every time it is synchronized.1
I also removed the
apiserver.servingCerts.caCrtvalue since it does not seem to be used anywhere.Footnotes
https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#random-data ↩