Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix powershell 7.5.0-rc.1 hook - Conda.psm1 #14430

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix powershell 7.5.0-rc.1 hook - Conda.psm1 #14430

wants to merge 4 commits into from

Conversation

jaideepheer
Copy link

@jaideepheer jaideepheer commented Dec 8, 2024 •
edited
Loading

Description

  • Fixed broken PowerShell 7.5.0-rc.1 hook commands.
    • Previous code was not filtering out empty args when calling conda commands, now it properly constructs conda commands
  • Before

image

  • After

image

  • Used Chat-Bot to debug and fix issues, please suggest improvements if any.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaideepheer jaideepheer requested a review from a team as a code owner December 8, 2024 10:44
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @jaideepheer.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1074), and ping the bot to refresh the PR.

@conda-bot conda-bot mentioned this pull request Dec 8, 2024
Merged
@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 9, 2024
@kenodegard
Copy link
Contributor

kenodegard commented Dec 9, 2024 •
edited
Loading

@jaideepheer What version of conda are you using?

The issue you've outlined would appear to be a duplicate of #14237 and was already corrected in conda 24.9.0 by setting empty variables to $null instead of "", see #14246

Can you update conda to a newer version and confirm if the issue persists?

@kenodegard kenodegard self-requested a review December 9, 2024 16:13
@eZioPan
Copy link

eZioPan commented Dec 29, 2024

Hi @kenodegard , I can confirm your fix make outermost conda call (before any conda activate) works. But after conda activate somthing, then conda cannot be used again. See #14292 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenodegard kenodegard Awaiting requested review from kenodegard

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaideepheer @conda-bot @travishathaway @kenodegard @eZioPan