-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: open participation page accessibility issues #1821
Open
thomassth
wants to merge
8
commits into
compdemocracy:edge
Choose a base branch
from
CivicTechTO:participation-a11y
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot of whitespace changes and linting that make this PR especially noisy. I might suggest isolating a11y concerns for a more succinct change set. |
thomassth
force-pushed
the
participation-a11y
branch
from
October 18, 2024 04:48
e1e5112
to
ab1330a
Compare
I noticed an update on Update release-docker-images.yml and I think this should not be applied to |
thomassth
force-pushed
the
participation-a11y
branch
from
October 18, 2024 23:30
ff39e84
to
f967030
Compare
thomassth
changed the title
Participation a11y
Fix: open participation page accessibility issues (Axe)
Oct 18, 2024
thomassth
changed the title
Fix: open participation page accessibility issues (Axe)
Fix: open participation page accessibility issues
Oct 18, 2024
I have isolated the changes and removed linting & formatting. |
(cherry picked from commit 195a240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a number of accessibility issues on caught by axe on an open participation page.