Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned protobuf files #495

Merged
merged 26 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
fdcca78
proto: Add versioned cometbft proto files
mzabaluev Apr 6, 2023
784f976
Regenerate *.pb.go in the api folder
mzabaluev Apr 6, 2023
5a5beff
Move and adapt supporting code alongside *.pb.go
mzabaluev Apr 6, 2023
b1c79f9
Remove go_package directives from tendermint protos
mzabaluev Apr 6, 2023
ba3c574
Update proto imports in production code
mzabaluev Apr 6, 2023
9cbf604
Update proto imports in tests and examples
mzabaluev Apr 6, 2023
136791f
Update links to proto files in docs
mzabaluev Apr 6, 2023
a7ad099
Changelog entry for #495
mzabaluev Apr 6, 2023
32504b8
Bump govulncheck to use go 1.20.3
mzabaluev Apr 6, 2023
b431f7b
Suppress golangci lints on generated code/names
mzabaluev Apr 14, 2023
2c93cf3
Fix gofmt and goimports lints
mzabaluev Apr 14, 2023
b329316
Suppress more var-naming lints
mzabaluev Apr 14, 2023
5bf54e4
Update go.sum
mzabaluev Apr 14, 2023
ea29676
abci: fix structural literal lints
mzabaluev Apr 14, 2023
899eccb
Remove newline after file //nolint suppressions
mzabaluev Apr 14, 2023
40613ee
Suppress stylecheck linter on *.pb.go files
mzabaluev Apr 14, 2023
f78b19d
Suppress revive,stylecheck lints on alias files
mzabaluev Apr 14, 2023
9d41fd8
Fix an indent-error-flow lint in tests
mzabaluev Apr 14, 2023
5ee443d
Suppress style lints on SignedMsgType consts
mzabaluev Apr 14, 2023
c9ac8db
Edit changelog for #495
mzabaluev Apr 18, 2023
cc351d5
proto: fix the formatting
mzabaluev Apr 18, 2023
2b47221
proto: remove blockchain/v1
mzabaluev Apr 18, 2023
d2c36a9
proto: flatten VersionParams into a single version
mzabaluev Apr 18, 2023
cdf4e80
Regenerate protos for flattened VersionParams
mzabaluev Apr 18, 2023
fd54d1d
Merge branch 'mikhail/proto-version-suffixes' of github.com:cometbft/…
mzabaluev Apr 18, 2023
57e8a81
Revert SignedMsgProto member const names
mzabaluev Apr 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
proto: flatten VersionParams into a single version
As we are introducing whole new cometbft packages for the proto users,
it's no great sin to also apply cosmetic renamings retroactively to older
releases of the protocol, to reduce versioning of messages.
  • Loading branch information
mzabaluev committed Apr 18, 2023
commit d2c36a97b35c5c68509d5d874d3bd8be262c5b07
3 changes: 2 additions & 1 deletion proto/cometbft/types/v1/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ message VersionParams {
option (gogoproto.populate) = true;
option (gogoproto.equal) = true;

uint64 app_version = 1;
// Was named app_version in Tendermint 0.34
uint64 app = 1;
}

// HashedParams is a subset of ConsensusParams.
Expand Down
11 changes: 1 addition & 10 deletions proto/cometbft/types/v2/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ message ConsensusParams {
BlockParams block = 1;
v1.EvidenceParams evidence = 2;
v1.ValidatorParams validator = 3;
VersionParams version = 4;
v1.VersionParams version = 4;
}

// BlockParams contains limits on the block size.
Expand All @@ -28,12 +28,3 @@ message BlockParams {

reserved 3; // was TimeIotaMs see https://github.com/tendermint/tendermint/pull/5792
}

// VersionParams contains the ABCI application version.
message VersionParams {
option (gogoproto.populate) = true;
option (gogoproto.equal) = true;

// Was named app_version in v1
uint64 app = 1;
}
2 changes: 1 addition & 1 deletion proto/cometbft/types/v3/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ message ConsensusParams {
v2.BlockParams block = 1;
v1.EvidenceParams evidence = 2;
v1.ValidatorParams validator = 3;
v2.VersionParams version = 4;
v1.VersionParams version = 4;
ABCIParams abci = 5;
}

Expand Down