Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "OSA UCS" to "CIE XYZ" conversion. #759

Open
KelSolaar opened this issue Jan 20, 2021 · 1 comment
Open

Improve "OSA UCS" to "CIE XYZ" conversion. #759

KelSolaar opened this issue Jan 20, 2021 · 1 comment
Labels
API Defect Minor
Milestone
v0.4.7

Comments

@KelSolaar
Copy link
Member

KelSolaar commented Jan 20, 2021 •
edited
Loading

Our optimization process does not do a good job with dark colours and actually fails miserably, we should revise our approach:

image
image
image

References
@KelSolaar KelSolaar added this to the v0.4.0 milestone Jan 20, 2021
@KelSolaar
Copy link
Member Author

I gave a stab at a Newton-Raphson minimizer as described by Moroney (2003): https://github.com/colour-science/colour/blob/feature/osa_ucs/colour/algebra/optimize.py

Good thing is that it is vectorised, so it is super fast! Problem is that it does also fail for dark colours:

image

@KelSolaar KelSolaar modified the milestones: v0.4.0, v0.4.1, v0.4.2 Feb 19, 2022
@KelSolaar KelSolaar modified the milestones: v0.4.2, v0.4.3 Nov 27, 2022
@KelSolaar KelSolaar modified the milestones: v0.4.3, v0.4.4 Aug 25, 2023
@KelSolaar KelSolaar modified the milestones: v0.4.4, v0.4.5 Dec 19, 2023
@KelSolaar KelSolaar modified the milestones: v0.4.5, v0.4.6, v0.4.7 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Defect Minor
Projects
None yet
Milestone
v0.4.7
Development

No branches or pull requests
1 participant
@KelSolaar