super super super WIP mcp integration #1635
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theskcd
reviewed
Dec 16, 2024
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub struct MCPIntegrationToolQuery { | ||
| pub action: String, |
There was a problem hiding this comment.
any reason to keep this String or can we make this enum and make it properly typed, string feels weird over here
Comment on lines
+184
to
+186
| fn tool_input_format(&self) -> String { | ||
| r#"{"action":"list"} or {"action":"call","server_name":"string","tool_name":"string","arguments":{}}"#.to_string() | ||
| } |
There was a problem hiding this comment.
this format is generally used for parsing xml and not json which might lead to errors over here
| })?; | ||
|
|
||
| let mut tool_descriptors = Vec::new(); | ||
| for t in tools_array { |
There was a problem hiding this comment.
proper variable names please, I dont enjoy second guessing single variable names and looking for them in the codebase.. there is no need to be stingy with the variable name
| } | ||
|
|
||
| pub struct MCPIntegrationToolBroker { | ||
| servers: HashMap<String, Arc<Client>>, |
There was a problem hiding this comment.
any reason the servers here have Arc and not Client
darinkishore
commented
Dec 16, 2024
| @@ -85,4 +85,11 @@ pub enum ToolError { | |||
|
|
|||
| #[error("Readline error")] | |||
| ReadLineError, | |||
| } | |||
|
|
|||
| // Newly added error variants for integration tool usage | |||
| } | ||
|
|
||
| fn tool_description(&self) -> String { | ||
| // TODO: change description to aggregate descriptions of all servers (or maybe a simpler option?) |
Introduced an awaited `.with_mcp()` in the `ToolBroker` for MCP customization, ensuring async readiness. Updated various dependencies in `Cargo.lock`, including `thiserror`, `syn`, `serde`, `tokio`, and `tungstenite`, reflecting improvements and compatibility updates.
put it into the agent shits looping though idk why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think feasible implementation? will have to add tests.
test multiple servers as well.