Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] overriding commit types feat and fix default all CommitConfig flags to false #401

Open
sylver opened this issue Jul 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sylver
Copy link

sylver commented Jul 9, 2024

Describe the bug

When overriding special commit types feat and fix, to change their titles for instance, like

[commit_types]
feat = { changelog_title = "🌟 Features" }
fix = { changelog_title = "🐛 Bug Fixes" }

They don't trigger a bump anymore.

Expected behavior

Overriding the title of any of them should not default all other flags of their CommitConfig to false

Additional context

A workaround is to explicitly add the bump trigger flag in the custom config like

[commit_types]
feat = { changelog_title = "🌟 Features", bump_minor = true }
fix = { changelog_title = "🐛 Bug Fixes", bump_patch = true }

but a user should probably not have to do that, unless specified in the documentation that this is the way and mandatory when one wants to override the title of a special commit type.

The way it is implemented does not permit to easily merge the custom config with the default one and I'm not good enough in Rust yet to suggest something in a PR, sorry.

@sylver sylver added the bug Something isn't working label Jul 9, 2024
@sylver sylver changed the title [BUG] overriding commit types feat and fix default all flags to false [BUG] overriding commit types feat and fix default all CommitConfig flags to false Jul 9, 2024
@DaRacci
Copy link
Contributor

DaRacci commented Dec 5, 2024

I was just experiencing this, would make more sense for if declaring an existing default type to instead make it only override defined sections.

DaRacci added a commit to AMTSupport/tools that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants