Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: track actual memory usage in TimestampCache #14516

Merged
merged 2 commits into from
Mar 31, 2017
Merged

storage: track actual memory usage in TimestampCache #14516

merged 2 commits into from
Mar 31, 2017

Conversation

petermattis
Copy link
Collaborator

@petermattis petermattis commented Mar 31, 2017 •
edited by rjnn
Loading

Replace defaultEvictionSizeThreshold with defaultTimestampCacheSize
which defaults to 64 MB.

Fixes #14508

This change is Reviewable

@petermattis
storage: track actual memory usage in TimestampCache
2a5b99d 
Replace defaultEvictionSizeThreshold with defaultTimestampCacheSize
which defaults to 64 MB.

Fixes cockroachdb#14508
@petermattis
storage: lazily create the transaction key for the TimestampCache
6d12fc5 
This avoids a memory allocation in the common case that a request does
not need to be expanded.
@petermattis petermattis requested a review from bdarnell March 31, 2017 16:05
@bdarnell
Copy link
Contributor

:lgtm:

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@petermattis petermattis merged commit 605b000 into cockroachdb:master Mar 31, 2017
@petermattis petermattis deleted the pmattis/timestamp-cache-size branch March 31, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarnell bdarnell Awaiting requested review from bdarnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petermattis @bdarnell