Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: upgrade hyperloglog library #138546

Open
yuzefovich opened this issue Jan 7, 2025 · 1 comment · May be fixed by #138561
Open

stats: upgrade hyperloglog library #138546

yuzefovich opened this issue Jan 7, 2025 · 1 comment · May be fixed by #138561
Assignees
@yuzefovich
Labels
A-sql-table-stats Table statistics (and their automatic refresh). C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Jan 7, 2025 •
edited by cockroach-jira-scripts
Loading

We are using hyperloglog library of very old version v0.0.0-20181223111420 which has had some improvements since (v0.2.0 at the time of this writing), so we should consider upgrading it. The difficulty, however, is that the binary representation appears to have changed between the versions, so in mixed-version clusters if we have a distributed stats collection plan, we might run into errors like #137386, so we need to be careful with backwards-compatibility.

Jira issue: CRDB-46162
@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-sql-table-stats Table statistics (and their automatic refresh). T-sql-queries SQL Queries Team labels Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Jan 7, 2025
@yuzefovich yuzefovich mentioned this issue Jan 7, 2025
Open
@yuzefovich yuzefovich self-assigned this Jan 8, 2025
@yuzefovich yuzefovich moved this from Triage to 25.1 Release in SQL Queries Jan 8, 2025
@yuzefovich
Copy link
Member Author

This issue is dependent on #98550 - we need improved exec version mechanism for backwards-compatible change.

@yuzefovich yuzefovich linked a pull request Jan 8, 2025 that will close this issue
Open
@yuzefovich yuzefovich moved this from 25.1 Release to Active in SQL Queries Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-table-stats Table statistics (and their automatic refresh). C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Active
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rowexec: upgrade hyperloglog for table stats processors yuzefovich/cockroach
1 participant
@yuzefovich