Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how the nsupdate code works #3871

Open
wants to merge 1 commit into
base: release33
Choose a base branch
from

Conversation

fallsjo
Copy link

@fallsjo fallsjo commented Dec 26, 2024

  • Now supports individual keys for different NS servers.
  • Updates will only be sent to known NS servers.

Linked Items

Fixes #

Description

Refactor the existing nsupdate code so that it supports different sig keys for different servers.
Updates will only be attempted if the name server is know (in the configuration settings)

Behaviour changes

Old: The code assumes you use the same tsig-key for all name servers, and it will send updates to any server using the same key.

New: The update allows (force) you to configure tsig-keys for each name server that you want to be able to send updates to.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

* Now supports individual keys for different NS servers.
* Updates will only be sent to known NS servers.
@fallsjo
Copy link
Author

fallsjo commented Dec 29, 2024

I'm unsure how to handle the migration/schema update that this pull-request contain.

If it needs to be handled differently please let me know how, or if there is any developer references available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant