Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud-Init Support #3293

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Cloud-Init Support #3293

wants to merge 13 commits into from

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Dec 3, 2022 •
edited
Loading

Linked Items

Fixes #3218

This should be rebased and reviewed after #3295

Description

Initial cloud-init support.

Behaviour changes

Old: HTTP route for autoinstallation was not compatible with cloud-init.

New: HTTP route was extended to allow cloud-init to request its files.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Dec 3, 2022
@SchoolGuy SchoolGuy changed the title Feature/cloud init Cloud-Init Support Dec 3, 2022
@github-actions github-actions bot added the API label Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 3, 2022 •
edited
Loading

Codecov Report

Base: 65.51% // Head: 65.37% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (0b55e74) compared to base (3da0a32).
Patch coverage: 40.75% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
- Coverage   65.51%   65.37%   -0.14%     
==========================================
  Files         113      119       +6     
  Lines       15151    15278     +127     
==========================================
+ Hits         9926     9988      +62     
- Misses       5225     5290      +65
Impacted Files Coverage Δ
cobbler/services.py 0.00% <0.00%> (ø)
cobbler/autoinstall/generate/legacy.py 11.11% <11.11%> (ø)
cobbler/autoinstall/generate/autoyast.py 15.00% <15.00%> (ø)
cobbler/autoinstall/generate/cloud_init.py 33.33% <33.33%> (ø)
cobbler/autoinstall/generate/__init__.py 36.00% <36.00%> (ø)
cobbler/autoinstall/generate/base.py 53.84% <53.84%> (ø)
cobbler/remote.py 59.04% <70.83%> (+0.01%) ⬆️
cobbler/autoinstall/generate/kickstart.py 75.00% <75.00%> (ø)
cobbler/autoinstall/generate/preseed.py 75.00% <75.00%> (ø)
cobbler/api.py 71.94% <81.25%> (+0.41%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2022
@github-actions github-actions bot added the tests label Dec 18, 2022
@SchoolGuy
Copy link
Member Author

Reminder: Refactor windows autoinstallation to first-level with this PR.

@SchoolGuy SchoolGuy mentioned this pull request Jan 7, 2023
Closed
@SchoolGuy SchoolGuy mentioned this pull request May 16, 2023
Open
This was referenced May 30, 2023
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API documentation Improvements or additions to documentation tests
Projects
Cobbler Server
Status: Pull Requests
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Cloud-Init Support
1 participant
@SchoolGuy