Setting.py: Change property name #6071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay so this is my second PR now Travis reports |
imnitishng
force-pushed
the
setting_issue_new
branch
2 times, most recently
from
b51046c to
d7af210
Compare
|
Can someone have a look at this PR and merge it? This is my first PR! |
frextrite
suggested changes
Sep 12, 2019
There was a problem hiding this comment.
Thanks for the PR @imnitishng. The changes look good, however, change Fixes to Closes in the PR and commit body since this is not a bug.
imnitishng
force-pushed
the
setting_issue_new
branch
from
d7af210 to
8b97b4a
Compare
Change property name from line_number-->start_line_number Closes coala#5983
imnitishng
force-pushed
the
setting_issue_new
branch
from
8b97b4a to
73377ec
Compare
|
Done! |
This was referenced Jan 11, 2020
DestroyerAlpha
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change property name in class
Settingfromline_number-->start_line_numberCloses #5983
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!