re-organize `RecoMuon/L3TrackFinder` such that all plugins are defined in `plugins` folder #47064

mmusich · 2025-01-08T20:54:17Z

PR description:

Title says it all, as per #47049 (comment)

merge plugins header with implementation in the same file;
move the plugins file in the plugins folder;
remove SealModules.cc file;

Technical, no regression expected.

PR validation:

Passes:

runTheMatrix.py --what upgrade -l 29850.778 --ibeos
addOnTests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Cc: @Parsifal-2045

cmsbuild · 2025-01-08T20:54:40Z

cms-bot internal usage

mmusich · 2025-01-08T20:56:07Z

test parameters:

workflow_opts= -w upgrade
workflow = 29834.0, 29834.777, 29834.778, 29850.0, 29850.777, 29850.778
enable = hlt_p2_integration, hlt_p2_timing

cmsbuild · 2025-01-08T20:56:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47064/43224

cmsbuild · 2025-01-08T20:57:04Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

RecoMuon/L3TrackFinder (reconstruction, hlt)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-01-08T20:57:18Z

please test

Parsifal-2045 · 2025-01-08T20:58:43Z

This afternoon I have been working on all the sub-modules in RecoMuon implementing something similar. If this is something we want to go through with, I can rebase on this PR and remove all SealModules from the RecoMuon package (and maybe some other packages later)

mmusich · 2025-01-08T20:59:46Z

If this is something we want to go through with, I can rebase on this PR and remove all SealModules from the RecoMuon package (and maybe some other packages later)

please do so.

Parsifal-2045 · 2025-01-08T21:00:57Z

If this is something we want to go through with, I can rebase on this PR and remove all SealModules from the RecoMuon package (and maybe some other packages later)

please do so.

I'm running some tests tonight to verify that everything's fine. I should have a PR open by tomorrow

cmsbuild · 2025-01-08T22:36:16Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fec07/43686/summary.html
COMMIT: 9264847
CMSSW: CMSSW_15_0_X_2025-01-08-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47064/43686/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fec07/43686/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fec07/43686/git-merge-result

RelVals

29834.778

----- Begin Fatal Exception 08-Jan-2025 23:00:09 CET-----------------------
An exception of category 'PluginCacheError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'Phase2HLTMuonSelectorForL3' should have been in loadable
 '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
 but was not there.  This means the plugin cache is incorrect.  Please run 'EdmPluginRefresh /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
----- End Fatal Exception -------------------------------------------------

29850.778

----- Begin Fatal Exception 08-Jan-2025 22:59:06 CET-----------------------
An exception of category 'PluginCacheError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'Phase2HLTMuonSelectorForL3' should have been in loadable
 '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
 but was not there.  This means the plugin cache is incorrect.  Please run 'EdmPluginRefresh /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
----- End Fatal Exception -------------------------------------------------

29850.777

----- Begin Fatal Exception 08-Jan-2025 22:59:06 CET-----------------------
An exception of category 'PluginCacheError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'Phase2HLTMuonSelectorForL3' should have been in loadable
 '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
 but was not there.  This means the plugin cache is incorrect.  Please run 'EdmPluginRefresh /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-07-2300/lib/el8_amd64_gcc12/pluginRecoMuonL3MuonProducer.so'
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

29834.777

HLT P2 Timing: chart

…in plugins folder

cmsbuild · 2025-01-09T07:05:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47064/43229

cmsbuild · 2025-01-09T07:05:45Z

Pull request #47064 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

mmusich · 2025-01-09T07:17:01Z

please test

cmsbuild · 2025-01-09T10:05:47Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fec07/43691/summary.html
COMMIT: a2cd368
CMSSW: CMSSW_15_0_X_2025-01-08-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47064/43691/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4464818
DQMHistoTests: Total failures: 1054
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4463744
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 238 log files, 208 edm output root files, 55 DQM output files
TriggerResults: no differences found

mmusich · 2025-01-09T10:16:18Z

+hlt

changes in HGCal validation plots are spurious (see Non reproducibility in HGCal DQM #46416 - recently solved)

jfernan2 · 2025-01-09T10:51:08Z

+1

cmsbuild · 2025-01-09T10:51:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-01-09T14:06:42Z

+1

cmsbuild added this to the CMSSW_15_0_X milestone Jan 8, 2025

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 8, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 8, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 8, 2025

re-organize RecoMuon/L3TrackFinder such that all plugins are defined …

a2cd368

…in plugins folder

mmusich force-pushed the mm_dev_reorganizeRecoMuonL3TrackFinder branch from 9264847 to a2cd368 Compare January 9, 2025 07:02

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 9, 2025

cmsbuild removed the code-checks-pending label Jan 9, 2025

cmsbuild added the code-checks-approved label Jan 9, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 9, 2025

cmsbuild added hlt-approved and removed hlt-pending labels Jan 9, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jan 9, 2025

Parsifal-2045 mentioned this pull request Jan 9, 2025

Remove all SealModules from the RecoMuon package #47065

Merged

cmsbuild added orp-approved and removed orp-pending labels Jan 9, 2025

cmsbuild merged commit 684a740 into cms-sw:master Jan 9, 2025
14 checks passed

mmusich deleted the mm_dev_reorganizeRecoMuonL3TrackFinder branch January 9, 2025 14:07

This was referenced Jan 9, 2025

L1 tracking update #47067

Open

[UBSAN]Properly initialize datamembers for move operator #47074

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

re-organize `RecoMuon/L3TrackFinder` such that all plugins are defined in `plugins` folder #47064

re-organize `RecoMuon/L3TrackFinder` such that all plugins are defined in `plugins` folder #47064

mmusich commented Jan 8, 2025

cmsbuild commented Jan 8, 2025 •

edited

Loading

mmusich commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

mmusich commented Jan 8, 2025

Parsifal-2045 commented Jan 8, 2025

mmusich commented Jan 8, 2025

Parsifal-2045 commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

mmusich commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

mmusich commented Jan 9, 2025

jfernan2 commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

mandrenguyen commented Jan 9, 2025

re-organize RecoMuon/L3TrackFinder such that all plugins are defined in plugins folder #47064

re-organize RecoMuon/L3TrackFinder such that all plugins are defined in plugins folder #47064

Conversation

mmusich commented Jan 8, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jan 8, 2025 • edited Loading

mmusich commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

mmusich commented Jan 8, 2025

Parsifal-2045 commented Jan 8, 2025

mmusich commented Jan 8, 2025

Parsifal-2045 commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

RelVals

cmsbuild commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

mmusich commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

Comparison Summary

mmusich commented Jan 9, 2025

jfernan2 commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

mandrenguyen commented Jan 9, 2025

re-organize `RecoMuon/L3TrackFinder` such that all plugins are defined in `plugins` folder #47064

re-organize `RecoMuon/L3TrackFinder` such that all plugins are defined in `plugins` folder #47064

cmsbuild commented Jan 8, 2025 •

edited

Loading