-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StreamID parameter to Transformer callback functions #47036
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47036/43159
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @fwyzard, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable gpu |
@cmsbuild, please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
The StreamID will be needed to implement implicit host-to-device copies for Alpaka EDProducers
935bb55
to
0e28aeb
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47036/43161
|
Pull request #47036 was updated. @Dr15Jones, @cmsbuild, @fwyzard, @makortel, @smuzaffar can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: GpuUnitTests GPU Unit TestsI found 2 errors in the following unit tests: ---> test testCudaDeviceAdditionWrapper had ERRORS ---> test testCudaDeviceAdditionKernel had ERRORS Comparison SummarySummary:
GPU Comparison SummarySummary:
|
ignore tests-rejected with ib-failure |
+heterogeneous |
The code seems fine. The only downside I see is that this interface would not work if we were to extend this system to also work with Runs and LuminosityBlocks. I think it is fine to not consider that until such a change is needed. |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds
edm::StreamID
parameter to the callback functions for the Transformer EDModule ability. Knowing theStreamID
would be useful in implementing implicit host-to-device data product copies for EDProducers (in addition to their implicit device-to-host copies).Resolves cms-sw/framework-team#1130
PR validation:
Framework unit tests run.