Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterSet/Config.py: Use realpath of cmssw area to avoid symlink issue #47024

Merged
merged 1 commit into from
Dec 24, 2024
Merged

ParameterSet/Config.py: Use realpath of cmssw area to avoid symlink issue #47024

merged 1 commit into from
Dec 24, 2024
+1 −1

Conversation

smuzaffar
Copy link
Contributor

This fixes the FW unit test [a]. The issue is that python modules are loaded using realpath while https://github.com/cms-sw/cmssw/blob/master/FWCore/ParameterSet/python/Config.py#L55 is not resolving the symlink [b]. This change fix this unit test by using the realpath of CMSSW_BASE, CMSSW_RELEASE_BASE and CMSSW_FULL_RELEASE_BASE env

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_15_0_ROOT6_X_2024-12-22-2300/unitTestLogs/FWCore/Integration#/3356-3356

cmsRun importRestrictions2.py ------------------------------------------------------------
Failure cmsRun importRestrictions2.py: status 1

---> test TestIntegrationParameterSet had ERRORS

[b] CMSSWPath has /cvmfs/cms-ib.cern.ch/sw/x86_64/week1 which is symlink to /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02869 while the import module has realpth /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02869/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-22-0000/src/FWCore/ParameterSet/python/Config.py

(Pdb) print(CMSSWPath)
['/build/muz/br/cvmfs/CMSSW_15_0_X_2024-12-22-0000', '/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-22-0000']
(Pdb) print(item)
FrameInfo(frame=<frame at 0x1ac9720, file '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02869/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-22-0000/src/FWCore/ParameterSet/python/Config.py', line 63, code checkImportPermission>, filename='/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02869/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-22-0000/src/FWCore/ParameterSet/python/Config.py', lineno=59, function='checkImportPermission', code_context=['    for item in inspect.stack():\n'], index=0)

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 23, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 23, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47024/43141

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d7737/43598/summary.html
COMMIT: c28f551
CMSSW: CMSSW_15_0_X_2024-12-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47024/43598/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 415
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818295
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

Comparison differences are related to #46416

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a89b1d2 into cms-sw:master Dec 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@smuzaffar @cmsbuild @makortel @mandrenguyen