Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HGCAL Validation reproducible #46962

Conversation

felicepantaleo
Copy link
Contributor

@felicepantaleo felicepantaleo commented Dec 16, 2024

This PR optimizes HGCalValidator and fixes #46416

It also produces simTracksters morphology plots that were previously filled only for reco objects.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2024

cms-bot internal usage

@felicepantaleo
Copy link
Contributor Author

  • type hgcal
  • type bugfix

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
  • Validation/HGCalValidation (dqm)

@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @hatakeyamak, @lecriste, @lgray, @missirol, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @vandreev11, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor Author

test parameters:

  • workflow_opts= -w upgrade
  • workflow = 29688.203

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef4b2a/43471/summary.html
COMMIT: 2a6032f
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46962/43471/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 76 lines to the logs
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3618291
  • DQMHistoTests: Total failures: 2170
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3616101
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 207 log files, 176 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 1 / 45 workflows

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46962 was updated. @Moanwar, @antoniovagnerini, @civanch, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef4b2a/43581/summary.html
COMMIT: d971df6
CMSSW: CMSSW_15_0_X_2024-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46962/43581/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+dqm

@civanch
Copy link
Contributor

civanch commented Dec 21, 2024

+1

regression is lost in tracker

@makortel
Copy link
Contributor

makortel commented Jan 8, 2025

@cmsbuild, please test

To refresh tests

@makortel
Copy link
Contributor

makortel commented Jan 8, 2025

@cms-sw/upgrade-l2 Could you review and sign? Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef4b2a/43684/summary.html
COMMIT: d971df6
CMSSW: CMSSW_15_0_X_2025-01-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46962/43684/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3927027
  • DQMHistoTests: Total failures: 2113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3924894
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 219 log files, 188 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@Moanwar
Copy link
Contributor

Moanwar commented Jan 8, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7915102 into cms-sw:master Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non reproducibility in HGCal DQM
8 participants