-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HGCAL Validation reproducible #46962
Make HGCAL Validation reproducible #46962
Conversation
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43034 |
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
+1 Size: This PR adds an extra 56KB to repository
Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46962/43038 |
Pull request #46962 was updated. @Moanwar, @antoniovagnerini, @civanch, @kpedro88, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please check and sign again. |
+1 Size: This PR adds an extra 36KB to repository
Comparison SummarySummary:
|
+dqm |
+1 regression is lost in tracker |
@cmsbuild, please test To refresh tests |
@cms-sw/upgrade-l2 Could you review and sign? Thanks! |
+1 Size: This PR adds an extra 16KB to repository
Comparison SummarySummary:
|
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR optimizes HGCalValidator and fixes #46416
It also produces simTracksters morphology plots that were previously filled only for reco objects.