Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables for the additional MaxMemoryPreload-reported quantities #2412

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Add tables for the additional MaxMemoryPreload-reported quantities #2412

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0f503a6
Correction to formula for percentage fraction diff
gartung Dec 2, 2024
e6f2d5a
Update maxmem profile summary table with all requested stats
gartung Jan 7, 2025
2a396e6
Add move quantities. Add suggested formatting
gartung Jan 8, 2025
9be75ed
Add thousands commas to memory numbers.:
gartung Jan 8, 2025
5bb7277
Change line breaks into table cells in prep for flagging individual q…
gartung Jan 9, 2025
94832c3
Black formatting
gartung Jan 9, 2025
98f05bb
Add maximum memory used threshold levels and coloring
gartung Jan 9, 2025
100087d
black formatting
gartung Jan 9, 2025
e5a2354
Add move over highlighting of row. Remove borders between legend entr…
gartung Jan 10, 2025
13d2f11
black formaating
gartung Jan 10, 2025
07bbdec
Remove borders betwen step N values
gartung Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change line breaks into table cells in prep for flagging individual q… 
…uantities.
  • Loading branch information
@gartung
gartung committed Jan 9, 2025
commit 5bb72770a92ba940badbf23526b01239b8f9a917
230 changes: 173 additions & 57 deletions comparisons/compare-maxmem-summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def compare_maxmem_summary(**kwargs):
req_mem_pdiff = max_memory_pdiff_dict[step].get("total memory requested")
leak_mem_pdiff = max_memory_pdiff_dict[step].get("presently used")
nalloc_pdiff = max_memory_pdiff_dict[step].get("# allocations calls")
max_memory_adiff = max_memory_pr - max_memory_base
max_memory_adiff = max_memory_pr - max_memory_base if (max_mem_pr and max_mem_base) else 0.0
max_memory_pdiff = (
100 * (max_mem_pr - max_mem_base) / max_mem_base
if (max_mem_pr and max_mem_base)
Expand Down Expand Up @@ -125,7 +125,7 @@ def wffn(w):
return float(re.sub("_.*", "", w))

sortedworkflows = sorted(workflows.keys(), key=wffn)

print(sortedworkflows)
summaryLines = []
if summaryFormat == "html":
summaryLines += [
Expand All @@ -135,6 +135,7 @@ def wffn(w):
+ "<style> th, td {padding: 15px;}</style></head>",
"<body><h3>Summary of Maxmem Profiler Comparisons</h3><table>",
'<tr><th align="center">Workflow</th>'
+ '<th align="center">Quantity</th>'
+ '<th align="center">Legend</th>'
+ '<th align="center">Step1</th>'
+ '<th align="center">Step2</th>'
Expand All @@ -153,23 +154,186 @@ def wffn(w):
def stepfn(step):
return int(step.replace("step", ""))

max_mem_pr, max_mem_base, max_mem_pdiff = 0, 0, 0
for workflow in sortedworkflows:
summaryLine = []
if summaryFormat == "html":
summaryLine += [
"<tr>",
' <td align="left"><a href="'
' <td rowspan="26"><a href="'
+ resultsURL
+ '/%s/">' % workflow
+ "%s</a></td>" % workflow,
'<td style="white-space:nowrap"><b>max memory used:</b><BR>&lt;baseline (MB)&gt;<BR>&lt;pull request (MB)&gt;<BR>&lt PR - baseline&gt<BR>&lt;100* (PR - baseline)/baseline&gt;<BR>',
"<b>total memory requested:</b><BR>&lt;baseline (MB)&gt;<BR>&lt;pull request (MB)&gt;<BR>&lt PR - baseline&gt<BR>&lt;100* (PR - baseline)/baseline&gt;<BR>",
"<b>#allocation calls:</b><BR>&lt;baseline (MB)&gt;<BR>&lt;pull request (MB)&gt;<BR>&lt PR - baseline&gt<BR>&lt;100* (PR - baseline)/baseline&gt;<BR>",
"<b>memory leaked:</b><BR>&lt;baseline (MB)&gt;<BR>&lt;pull request (MB)&gt;<BR>&lt PR - baseline&gt<BR>&lt;100* (PR - baseline)/baseline&gt;<BR>",
"<b>#allocation calls leaked:</b><BR>&lt;baseline (MB)&gt;<BR>&lt;pull request (MB)&gt;<BR>&lt PR - baseline&gt<BR>&lt;100* (PR - baseline)/baseline&gt;<BR>",
]

summaryLine += ['<tr><th rowspan="5" style="white-space:nowrap"> max memory used:</th>']
summaryLine += ["<tr><td>&lt;pull request (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["max memory pr"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["max memory base"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;PR - baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["max memory adiff"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;100 * (PR - baseline)/baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.3f}".format(workflows[workflow][step]["max memory pdiff"]),
"%</td>"
]
summaryLine += ["</tr>",]

summaryLine += ['<tr><th rowspan="5" style="white-space:nowrap"> total memory request:</th>']
summaryLine += ["<tr><td>&lt;pull request (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["req memory pr"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["req memory base"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;PR - baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["req memory adiff"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;100 * (PR - baseline)/baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.3f}".format(workflows[workflow][step]["req memory pdiff"]),
"%</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["</tr>",]
summaryLine += ['<tr><th rowspan="5" style="white-space:nowrap"> # allocation calls:</th>']
summaryLine += ["<tr><td>&lt;pull request &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated pr"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated base"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;PR - baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated adiff"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;100 * (PR - baseline)/baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.3f}".format(workflows[workflow][step]["nallocated pdiff"]),
"%</td>"
]
summaryLine += ["</tr>",]
summaryLine += ['<tr><th rowspan="5" style="white-space:nowrap"> memory leaked:</th>']
summaryLine += ["<tr><td>&lt;pull request (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["leak memory pr"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["leak memory base"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;PR - baseline (MB)&gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.2f}".format(workflows[workflow][step]["leak memory adiff"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;100 * (PR - baseline)/baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.3f}".format(workflows[workflow][step]["leak memory pdiff"]),
"%</td>"
]
summaryLine += ["</tr>",]
summaryLine += ['<tr><th rowspan="5" style="white-space:nowrap"> # allocation calls leaked:</th>']
summaryLine += ["<tr><td>&lt;pull request &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated pr"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated base"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;PR - baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,}".format(workflows[workflow][step]["nallocated adiff"]),
"</td>"
]
summaryLine += ["</tr>",]
summaryLine += ["<tr><td>&lt;100 * (PR - baseline)/baseline &gt;</td>"]
for step in sorted(workflows[workflow].keys(), key=stepfn):
summaryLine += [
"<td>",
"{:,.3f}".format(workflows[workflow][step]["nallocated pdiff"]),
"%</td>"
]
summaryLine += ["</tr>",]
summaryLines += summaryLine

for step in sorted(workflows[workflow].keys(), key=stepfn):
max_mem_pr = workflows[workflow][step]["max memory pr"]
max_mem_base = workflows[workflow][step]["max memory base"]
Expand Down Expand Up @@ -205,54 +369,6 @@ def stepfn(step):
color = 'bgcolor="red"'
cellString += color
cellString += ">"
if summaryFormat == "html":
summaryLine += [
cellString
+ "<br/>"
+ "{:,.2f}".format(max_mem_base)
+ "<br/>"
+ "{:,.2f}".format(max_mem_pr)
+ "<br/>"
+ "{:,.2f}".format(max_mem_adiff)
+ "<br/>"
+ "%0.3f" % max_mem_pdiff
+ "%<br/><br/>"
+ "{:,.2f}".format(req_mem_base)
+ "<br/>"
+ "{:,.2f}".format(req_mem_pr)
+ "<br/>"
+ "{:,.2f}".format(req_mem_adiff)
+ "<br/>"
+ "%0.3f" % req_mem_pdiff
+ "%<br/><br/>"
+ "{:,}".format(nalloc_base)
+ "<br/>"
+ "{:,}".format(nalloc_pr)
+ "<br/>"
+ "{:,}".format(nalloc_adiff)
+ "<br/>"
+ "%0.3f" % nalloc_pdiff
+ "%<br/><br/>"
+ "{:,.2f}".format(leak_mem_base)
+ "<br/>"
+ "{:,.2f}".format(leak_mem_pr)
+ "<br/>"
+ "{:,.2f}".format(leak_mem_adiff)
+ "<br/>"
+ "%0.3f" % leak_mem_pdiff
+ "%<br/><br/>"
+ "{:,}".format(nlalloc_base)
+ "<br/>"
+ "{:,}".format(nlalloc_pr)
+ "<br/>"
+ "{:,}".format(nlalloc_adiff)
+ "<br/>"
+ "%0.3f" % nlalloc_pdiff
+ "%</td>"
]
if summaryFormat == "html":
summaryLine += ["</tr>"]
summaryLines += summaryLine

if summaryFormat == "html":
summaryLines += [
Expand Down
Loading