feat: add sum of weights for BTA_ttbar workflow, fix typo in suball script and make basepath in BTA producers configurable #111
+4,353
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmissioning into btv_dilep_wf
… of weights for BTA_ttbar workflow
Ming-Yan
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Hi @philippgadow this all looks good to me ! Thanks for the PR
Is there any changes you want to include further in this PR, if not we are good to merge :)
Ming-Yan
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Sorry noticing one change after approve it @philippgadow could you please have a look with this change?
Comment on lines
+527
to
+530
| if "Run3" in self._campaign: | ||
| passMetSel = events.PuppiMET.pt > 0 | ||
| else: | ||
| passMetSel = events.MET.pt > 0 |
There was a problem hiding this comment.
Apologies, did not find out the implementation was using the JME_shifts
Indeed in the functions we already implement the JEC with puppiMET and replace it as MET branch.
If you use the puppiMET branch, this might not propagate the JEC correction correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and fixes to the BTA workflow and associated scripts and configurations:
Feature Addition:
BTA_ttbarworkflow (LHE PDF weights not considered for the moment).basepathandoutput_dirinBTA_producerandBTA_ttbar_producerworkflows for greater flexibility in file management.Bug Fixes:
suballscript where variablespaserwere incorrectly referenced asparser, ensuring proper command-line parsing functionality.events.PuppiMET.pteverywhere inBTA_ttbar_producerworkflow if analysis is Run3Configuration Update:
test_env.ymlto replacedefaultswithnodefaultsin the conda channel configuration, removing dependencies on Anaconda, which is not free to use for organisations with more than 200 collaborators.