Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursive and unhashable closure #90

Merged
merged 14 commits into from
May 30, 2017
Merged

recursive and unhashable closure #90

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
da4dd39
support recursive closure cells
May 25, 2017
ba23a20
support unhashable closure values
May 25, 2017
2c49ba0
pypy fixes and _cell_set definition update
May 25, 2017
4b251a0
test the expected failure for pypy
May 25, 2017
6d8ec33
add test for f.__closure__ preservation
May 25, 2017
9e11439
2.6 compat for TestCase.assertIsNone
May 25, 2017
121604a
don't send the closure twice on pypy
May 25, 2017
ac85930
update closure serialization for pypy
May 25, 2017
55cd6fd
use pytest.raises instead of xfail
May 25, 2017
cb524a4
support pypy
May 25, 2017
ed7a73c
clean up names and inline single-use functions
May 25, 2017
6656cca
add comment pointing out my one weird trick for mutating a cell
May 26, 2017
26c319c
use an empty cell instead of cell(None)
May 26, 2017
cf882c6
add cell manipulation helper unit tests
May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test the expected failure for pypy
  • Loading branch information
Joe Jevnik committed May 25, 2017
commit 4b251a062be28dfc8cdb2639285d37e50c9c6fb3
13 changes: 13 additions & 0 deletions tests/cloudpickle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,19 @@ def g(n):
g2 = pickle_depickle(f2(2))
self.assertEqual(g2(5), 240)

@pytest.mark.skipif(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test actually should succeed on PyPy, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is a mistake

supports_recursive_closure,
reason="Recursive closures shouldn't raise an exception if supported"
)
@pytest.mark.xfail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than a xfail, I'd like to see the specific exception tested for inside the test, so that we don't miss it failing for other reasons...

def test_recursive_closure_unsupported(self):
def f1():
def g():
return g
return g

pickle_depickle(f1())

def test_unhashable_closure(self):
def f():
s = set((1, 2)) # mutable set is unhashable
Expand Down