Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recents and favorites when entities are deleted #4431

Merged
merged 13 commits into from
Jul 24, 2020
Merged

Remove recents and favorites when entities are deleted #4431

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ed9c6ae
Improve recent and favourites display
nwmac Jul 5, 2020
c2e713d
Remove debug logging
nwmac Jul 5, 2020
9581421
Remove debug logging/subscription leak
nwmac Jul 6, 2020
b142e22
Unit test fix
nwmac Jul 6, 2020
17b026d
Remove recents and favorites when entities are deleted
nwmac Jul 7, 2020
92dc78a
Merge remote-tracking branch 'origin/master' into remove-on-delete
nwmac Jul 9, 2020
754b600
Fix merge issues
nwmac Jul 9, 2020
7260a94
Fix merge issue
nwmac Jul 9, 2020
c98b6b6
Tidy up and improve following PR feedback
nwmac Jul 10, 2020
d605ac7
Remove out of date comment
nwmac Jul 10, 2020
86e97c5
Merge remote-tracking branch 'origin/master' into remove-on-delete
nwmac Jul 23, 2020
98e887f
Fixed problem where clear was not working
nwmac Jul 23, 2020
076ae8a
Check favorite exists before deleting
nwmac Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debug logging/subscription leak
  • Loading branch information
@nwmac
nwmac committed Jul 6, 2020
commit 9581421cd26b988ec7b55cefaad22a969b65e5ba
9 changes: 1 addition & 8 deletions ...frontend/packages/core/src/shared/components/recent-entities/recent-entities.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from 'frontend/packages/store/src/reducers/current-user-roles-reducer/recently-visited.reducer.helpers';
import * as moment from 'moment';
import { Observable, of as observableOf } from 'rxjs';
import { first, map } from 'rxjs/operators';
import { map } from 'rxjs/operators';

import { AppState } from '../../../../../store/src/app-state';
import { endpointEntityType } from '../../../../../store/src/helpers/stratos-entity-factory';
Expand Down Expand Up @@ -54,13 +54,6 @@ export class RecentEntitiesComponent {
public hasHits$: Observable<boolean>;
constructor(store: Store<AppState>) {
const recentEntities$ = store.select(recentlyVisitedSelector);

recentEntities$.pipe(first()).subscribe(e => {
console.log('recent entities');
console.log(e);
console.log(Object.keys(e).length);
});

this.recentEntities$ = recentEntities$.pipe(
map(entities => Object.values(entities)),
map((entities: IRecentlyVisitedEntity[]) => {
Expand Down