Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: Improve scaling of service instances #4162

Merged
merged 23 commits into from
Mar 18, 2020
Merged

Scalability: Improve scaling of service instances #4162

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b7dcdf5
Fix delete org when org contains spaces
richard-cox Mar 10, 2020
b3e03f8
Fix scaling related test scripts
richard-cox Mar 10, 2020
5e23ea7
Fix double fetching of missing user relations for getUser
richard-cox Mar 10, 2020
4d60312
Fix create many services script
richard-cox Mar 11, 2020
7088585
Scaling improvements
richard-cox Mar 11, 2020
1ca5dd4
Fix handling of generic errors to cf endpoints
richard-cox Mar 11, 2020
57f1dff
Fix SI Delete
richard-cox Mar 11, 2020
c62fa1e
Fix UPSI Delete
richard-cox Mar 11, 2020
b04a775
Handle error message being in error.status OR as a string in jetstrea…
richard-cox Mar 11, 2020
25ae44a
Block displaying of service wall and cf routes lists until cf/org/spa…
richard-cox Mar 11, 2020
b999a4f
Scaling Fixes
richard-cox Mar 12, 2020
6845aaa
Fix failing test
richard-cox Mar 12, 2020
9067352
Merge remote-tracking branch 'origin/master' into scale-related-fixes
richard-cox Mar 13, 2020
7e2de04
Fix cf-user getUsers
richard-cox Mar 13, 2020
84d7f21
Merge remote-tracking branch 'origin/scale-related-fixes' into scale-…
richard-cox Mar 13, 2020
c61feef
Fixes after merge
richard-cox Mar 13, 2020
a088e13
Fix unit test
richard-cox Mar 13, 2020
8e45bc7
Merge remote-tracking branch 'origin/master' into scale-related-fixes
richard-cox Mar 16, 2020
d06034d
Merge remote-tracking branch 'origin/scale-related-fixes' into scale-…
richard-cox Mar 16, 2020
15ba660
Fix unit test
richard-cox Mar 17, 2020
e426dc2
Merge remote-tracking branch 'origin/master' into scale-related-fixes…
richard-cox Mar 18, 2020
cf32d00
Fix bug from e2e test
richard-cox Mar 18, 2020
069492c
Remove duplicated line
richard-cox Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix UPSI Delete 
- Delete of entity was fine, however it was not removed from list
- With bug entity was still not visible in list afterwards only due to nulls filtered out in list
  • Loading branch information
@richard-cox
richard-cox committed Mar 11, 2020
commit c62fa1ec79c91c4c0b08c3b80510f62f4a3083fd
9 changes: 3 additions & 6 deletions ...rc/entity-request-pipeline/entity-request-base-handlers/success-entity-request.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,12 @@ export function successEntityHandler(
!action.updatingKey &&
(requestType === 'create' || requestType === 'delete')
) {
const proxySafeEntityConfig = action.proxyPaginationEntityConfig ? action.proxyPaginationEntityConfig : action;
// FIXME: Look at using entity config instead of actions in these actions ctors #3975
if (action.removeEntityOnDelete) {
actionDispatcher(new ClearPaginationOfEntity(action, action.guid));
actionDispatcher(new ClearPaginationOfEntity(proxySafeEntityConfig, action.guid));
} else {
if (action.proxyPaginationEntityConfig) {
actionDispatcher(new ClearPaginationOfType(action.proxyPaginationEntityConfig));
} else {
actionDispatcher(new ClearPaginationOfType(action));
}
actionDispatcher(new ClearPaginationOfType(proxySafeEntityConfig));
}

if (Array.isArray(action.clearPaginationEntityKeys)) {
Expand Down