Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitz - User Service & Deploy from git fixes #4062

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Blitz - User Service & Deploy from git fixes #4062

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4432203
Move createDefaultUserRelations to core file
richard-cox Dec 12, 2019
59f2799
Fix user service
richard-cox Dec 12, 2019
15945ff
Fix super sluggish behaviour when deploying from github
richard-cox Dec 12, 2019
f3d3f26
Fix getMatchingRepositories
richard-cox Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix getMatchingRepositories
  • Loading branch information
@richard-cox
richard-cox committed Dec 12, 2019
commit f3d3f26969ff0c49ff14a10ee42dec8e6429ac70
6 changes: 4 additions & 2 deletions ...cations/deploy-application/deploy-application-step2/deploy-application-step2.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { HttpClient } from '@angular/common/http';
import { AfterContentInit, Component, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
import { NgForm } from '@angular/forms';
import { ActivatedRoute } from '@angular/router';
Expand Down Expand Up @@ -123,7 +124,8 @@ export class DeployApplicationStep2Component
private store: Store<CFAppState>,
route: ActivatedRoute,
private paginationMonitorFactory: PaginationMonitorFactory,
private scmService: GitSCMService
private scmService: GitSCMService,
private httpClient: HttpClient
) {
this.selectedSourceType = getAutoSelectedDeployType(route);
if (this.selectedSourceType) {
Expand Down Expand Up @@ -320,7 +322,7 @@ export class DeployApplicationStep2Component

return observableTimer(500).pipe(
take(1),
switchMap(() => this.scm.getMatchingRepositories(name)),
switchMap(() => this.scm.getMatchingRepositories(this.httpClient, name)),
catchError(e => observableOf(null)),
tap(suggestions => this.cachedSuggestions[cacheName] = suggestions)
);
Expand Down