Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 8 Migration #3950

Merged
merged 55 commits into from
Nov 19, 2019
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
814d697
ng update wip
KlapTrap Oct 2, 2019
76a1259
More ng update wip
KlapTrap Oct 2, 2019
a0b326b
More ng update?
KlapTrap Oct 2, 2019
6c25e06
WIP angular 8 migration
KlapTrap Oct 3, 2019
d6b9433
Migrate autosclaer effects to use httpclient
KlapTrap Oct 3, 2019
5a358b3
WIP Migration
KlapTrap Oct 3, 2019
55725b0
Migrate httpclient
KlapTrap Oct 3, 2019
dbd280a
More http -> httpClient
KlapTrap Oct 3, 2019
9d1a837
Httpclient
KlapTrap Oct 3, 2019
71dff9e
Httpclient in cf effect
KlapTrap Oct 3, 2019
55ea22c
Remove http module
KlapTrap Oct 3, 2019
93c8b78
Setup httpClient fixes
KlapTrap Oct 3, 2019
0c191af
More httpclient
KlapTrap Oct 3, 2019
3b1339b
More http migration
KlapTrap Oct 3, 2019
b9ada20
ViewChild static migration
KlapTrap Oct 3, 2019
d25f043
Merge branch 'master' into angular-8
KlapTrap Oct 17, 2019
8f0ac85
WIP Angular 8 migration
KlapTrap Oct 17, 2019
75e0f29
Fix get action builders tying
KlapTrap Oct 17, 2019
0a9b962
Remove uneeded store freeze
KlapTrap Oct 18, 2019
411041c
Tidy up action dispatcher typing
KlapTrap Oct 18, 2019
b4a72bc
Added view child static field
KlapTrap Oct 18, 2019
a6da13e
WIP HTTP Client migration
KlapTrap Oct 18, 2019
f85e3f7
WIP Angular 8 migration
KlapTrap Oct 29, 2019
cd7317c
More angular 8 migrations
KlapTrap Oct 30, 2019
7a6cde8
Fixed some post angular update issues
KlapTrap Oct 31, 2019
dc695d6
Fixing ssh and log viewer
KlapTrap Oct 31, 2019
70850e4
Test fixes after angular 8 migration
KlapTrap Oct 31, 2019
5e86230
Fix `core` unit tests
richard-cox Nov 1, 2019
5965f57
Fix cf-autoscaler tests
richard-cox Nov 1, 2019
5f1a083
Fix immutablilty in unit tests
KlapTrap Nov 1, 2019
606d61f
Test bump of node version
richard-cox Nov 1, 2019
90ecdee
Fix istanbul see https://github.com/gotwarlost/istanbul/issues/868
KlapTrap Nov 1, 2019
10e7b20
Remove npm pegging
richard-cox Nov 1, 2019
5b113c8
Remove unused component
KlapTrap Nov 4, 2019
c820166
Remove delete scss file referance
KlapTrap Nov 4, 2019
1043eef
Another scss refernace delete
KlapTrap Nov 4, 2019
19d8fcd
Updated todos
KlapTrap Nov 4, 2019
0ac6b24
Added back in nav tab interface
KlapTrap Nov 4, 2019
8ae5e20
More tab typing
KlapTrap Nov 4, 2019
3c247ba
Remove protractor describe skipWhen usage
richard-cox Nov 4, 2019
27909e1
Change skipped tests from failure to a warning
KlapTrap Nov 4, 2019
d62c15b
WIP E2e fix
KlapTrap Nov 5, 2019
6bb359f
Fix e2e-dev & e2e-local. Print guthub url check success
richard-cox Nov 5, 2019
4f8f266
Get SSH Viewer component working again
nwmac Nov 5, 2019
b3b931f
Update log viewer connection status logic
KlapTrap Nov 11, 2019
f871195
Merge branch 'master' into angular-8
KlapTrap Nov 13, 2019
aa10d4b
Fix service instance update
KlapTrap Nov 13, 2019
d453d04
Fix application deploy
KlapTrap Nov 15, 2019
6c55044
Fix org delete
KlapTrap Nov 15, 2019
c70c701
Fix space delete
KlapTrap Nov 15, 2019
97a7131
Fix space creation after org creation
KlapTrap Nov 15, 2019
516aaca
Fix quota delete
KlapTrap Nov 18, 2019
9c31341
Fix route assign
KlapTrap Nov 18, 2019
05cc443
Fix space quota assign
KlapTrap Nov 18, 2019
2ddd7e8
Fix space update
KlapTrap Nov 18, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More http -> httpClient
  • Loading branch information
KlapTrap committed Oct 3, 2019
commit dbd280aa2f13d43a3c4c3c5f715ec1e69b7832e5
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Injectable } from '@angular/core';
import { Http } from '@angular/http';
import { Actions, Effect, ofType } from '@ngrx/effects';
import { Store } from '@ngrx/store';
import { of as observableOf } from 'rxjs';
Expand Down Expand Up @@ -57,7 +56,6 @@ export function createFailedGithubRequestMessage(error: any, logger: LoggerServi
@Injectable()
export class DeployAppEffects {
constructor(
private http: Http,
private actions$: Actions,
private store: Store<CFAppState>,
private logger: LoggerService,
Expand Down