Add Application Autoscaler Tab #3455

richard-cox · 2019-03-26T12:47:31Z

See #3266 for additional history

cfdreddbot · 2019-03-26T12:47:33Z

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

richard-cox

Not quite made it through yet, but here's a few very minor non-functional suggestions

...es/core/src/features/applications/edit-autoscaler-policy/edit-autoscaler-policy.component.ts

...e/src/shared/components/cards/card-autoscaler-default/card-autoscaler-default.component.html

...ared/components/list/list-types/app-autoscaler-event/cf-app-autoscaler-events-data-source.ts

...d/components/list/list-types/app-autoscaler-event/cf-app-autoscaler-events-config.service.ts

...list-types/app-autoscaler-metric-chart/app-autoscaler-metric-chart-card/combo-chart/index.ts

richard-cox

Along with inline comments there's some general things, all are minor and I don't think need to be done for the demo.

Autoscaler Tab

~~Refresh on slower loading connections and the policy slider in status is shown. This should be hidden as the rest~~ See LoadingPageComponent appears underneath content with z-index > 0 #3509
~~The status card shows a 'policy' slider with text 'Policy undefined' or 'Policy defined'. Think this text should just be 'Enabled' and 'Disabled' for the two states~~ 78405f3
Latest Events Card
- ~~When there are no events we should probably not show the link in the bottom right~~ 78405f3
- ~~The position of the link button appears over the table when there's no time based rules~~ 78405f3
Scheduled Limit Rules Card
- ~~The position of the edit button appears over the table when there's no time based rules~~ 78405f3

AutoScaler Metric Charts Modal

~~On first load the chart flashes three or four times. I think this could be a recent change we made that means observable chains on entities fire more often. I'm looking into this~~

Edit AutoScaler Policy Stepper

Scaling Rules, Recurring Schedules and Specific Dates steps
- I think we need to bring the 'Add' button up from the stepper controls to the same context as the list of rules. Something like an 'add' material icon with the text 'Add' in a button bottom left of the list would look good. d0ca5f6
Specific Dates Step
- On clicking finish
  - ~~Success - User should be taken back to the Autoscaler tab. Think you can do this by setting redirect: true in the StepOnNextResult returned by the step onNext function~~ d141f1d
  - ~~Failure - the onNext function should return { success: false, message: ''}. That will show the error in a snackbar at the bottom of the screen instead of in the main context~~ d141f1d

src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.types.ts

src/tsconfig.json

… of instance limits

KlapTrap

I'm a little nervous about the small amount of FE & BE unit tests. Unit tests are even more important when we don't own the code, it would really help us out when maintaining our codebase in the future.

src/frontend/packages/cf-autoscaler/src/cf-autoscaler-testing.module.ts

KlapTrap · 2019-06-11T14:36:17Z

src/frontend/packages/cf-autoscaler/src/cf-autoscaler.module.ts

+    loadChildren: './core/autoscaler.module#AutoscalerModule',
+    data: {
+      stratosNavigation: {
+        text: 'Applications',


Why do we need to add an entry to the stratosNavigation here?

Do you mean to remove the below code?

data: { stratosNavigation: { text: 'Applications', matIcon: 'apps', position: 20, hidden: of(true) } },

But when i remove this part of code, the https://localhost:4200/autoscaler/b5F2dF-Qr-r7yNWeDya0GTOL09c/2369e308-0733-40ce-ae9e-ed85fdbcca40/edit-autoscaler-policy and other autoscaler paths will failed to load with 404 error.
I don't know why... Could you please help me check? @richard-cox @KlapTrap

Yeah, that's what I thought. I think it would be worth rich and I taking a look and seeing what's going on, it doesn't seem right for you to have to do that!

src/frontend/packages/cf-autoscaler/src/core/autoscaler-helpers/autoscaler-transform-metric.ts

...dit-autoscaler-policy/edit-autoscaler-policy-step2/edit-autoscaler-policy-step2.component.ts

src/frontend/packages/core/src/core/utils.service.ts

...res/applications/application/application-tabs-base/tabs/events-tab/events-tab.component.scss

...ontend/packages/core/src/shared/components/list/data-sources-controllers/list-data-source.ts

src/frontend/packages/core/src/shared/services/metrics-range-selector-manager.service.ts

… into autoscaler

richard-cox · 2019-07-16T12:48:35Z

I've resolved the merge conflicts by bringing in v2-master. This has brought with it a change that breaks connecting to IBM Cloud via the endpoints page (SSO/cf push works fine though). There's a PR up that will fix this - #3715. I'll work on getting this through the gates again

- Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh

richard-cox added the in progress label Mar 26, 2019

richard-cox commented Mar 26, 2019

View reviewed changes

richard-cox commented Mar 27, 2019

View reviewed changes

src/frontend/packages/store/src/reducers/pagination-reducer/pagination-reducer.types.ts Outdated Show resolved Hide resolved

src/tsconfig.json Outdated Show resolved Hide resolved

zyjiaobj force-pushed the autoscaler branch 3 times, most recently from 3bcbeb2 to f18d245 Compare March 31, 2019 13:44

zyjiaobj force-pushed the autoscaler branch 8 times, most recently from e6813dc to d0ca5f6 Compare April 11, 2019 07:03

zyjiaobj and others added 15 commits April 22, 2019 09:33

[autoscaler] add autoscaler tab

e24f838

[autoscaler] show basic info in autoscaler tab

49ffa85

[autoscaler] add metric hostory request (fail)

6890375

[autoscaler] add autoscaler tables

02a5bbb

[autoscaler] request app metrics

4d66acb

[autoscaler] add policy edit page, event page and metric page

62e8d80

[autoscaler]auto-refresh metrics and history page

1e2e3a3

[autoscaler]reconstruct upon Monorepo - Phase 1

10b79e9

[autoscaler]add filter and auto-refresh for event and metric

da9e52b

[autoscaler] update policy edit page

799c4b6

[autoscaler] complete validators

100e3f5

[autoscaler] fix travis errors

0dceaf6

[autoscaler] add timezone in policy edit page

855963a

[autoscaler] go to upadte policy edit page when click on the edit btn…

10287af

… of instance limits

Minor tweaks

b74fe88

KlapTrap self-requested a review June 11, 2019 08:57

KlapTrap suggested changes Jun 12, 2019

View reviewed changes

KlapTrap added needs attention This PR needs attention and removed ready for review labels Jun 12, 2019

[autoscaler] fix upon Nathan's comments

32a31d7

zyjiaobj force-pushed the autoscaler branch from 664b9f9 to 32a31d7 Compare June 19, 2019 06:37

zyjiaobj added 2 commits June 19, 2019 14:38

Merge branch 'v2-master' of github.com:cloudfoundry-incubator/stratos…

56a7154

… into autoscaler

[autoscaler] add common 'refresh-icon' to use in autoscaler tab and list

91d8ef6

zyjiaobj force-pushed the autoscaler branch 2 times, most recently from deddf28 to 89a3000 Compare June 21, 2019 03:17

[autoscaler] remove usage of deepclone and intIfUndefined

660826c

zyjiaobj force-pushed the autoscaler branch from 89a3000 to 660826c Compare June 21, 2019 04:35

[autoscaler] fix policy validation bugs

efeac40

zyjiaobj mentioned this pull request Jun 26, 2019

Add Autoscaler e2e tests #3681

Merged

zyjiaobj and others added 3 commits July 4, 2019 17:36

Merge branch 'v2-master' of github.com:cloudfoundry-incubator/stratos…

812e89e

… into autoscaler

Merge remote-tracking branch 'origin/v2-master' into autoscaler

d0ed427

Update package lock

c05f44f

richard-cox added ready for review and removed needs attention This PR needs attention labels Jul 16, 2019

zyjiaobj force-pushed the autoscaler branch 2 times, most recently from b7edbff to c05f44f Compare July 22, 2019 08:35

zyjiaobj and others added 3 commits July 22, 2019 18:01

[autoscaler] fix conflits

24a3bfa

Fix syntax error

f24d164

[autoscaler] using app-polling-indicator to replace refresh-icon

87745f1

zyjiaobj force-pushed the autoscaler branch from 8d6ab83 to 87745f1 Compare July 23, 2019 03:14

richard-cox merged commit ddb19b7 into v2-master Jul 24, 2019

richard-cox deleted the autoscaler branch July 24, 2019 08:37

richard-cox mentioned this pull request Sep 16, 2019

Determine autoscaler availability via service with one time app autoscaler request #3583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Application Autoscaler Tab #3455

Add Application Autoscaler Tab #3455

richard-cox commented Mar 26, 2019

cfdreddbot commented Mar 26, 2019

richard-cox left a comment

richard-cox left a comment •

edited

Loading

KlapTrap left a comment

KlapTrap Jun 11, 2019

zyjiaobj Jun 19, 2019

KlapTrap Jun 19, 2019

richard-cox commented Jul 16, 2019

Add Application Autoscaler Tab #3455

Add Application Autoscaler Tab #3455

Conversation

richard-cox commented Mar 26, 2019

cfdreddbot commented Mar 26, 2019

richard-cox left a comment

Choose a reason for hiding this comment

richard-cox left a comment • edited Loading

Choose a reason for hiding this comment

KlapTrap left a comment

Choose a reason for hiding this comment

KlapTrap Jun 11, 2019

Choose a reason for hiding this comment

zyjiaobj Jun 19, 2019

Choose a reason for hiding this comment

KlapTrap Jun 19, 2019

Choose a reason for hiding this comment

richard-cox commented Jul 16, 2019

richard-cox left a comment •

edited

Loading