Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete git repository name #3372

Merged
merged 13 commits into from
Feb 14, 2019
Merged

Autocomplete git repository name #3372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
39729f0
Test
nwmac Jun 6, 2018
61929d7
Don't run with coverage when running unit tests in Travis
nwmac Jun 6, 2018
0fe99a6
Remove codecov reporter for now
nwmac Jun 6, 2018
c9ebf59
Merge remote-tracking branch 'origin/v2-master' into nwm-test
nwmac Nov 23, 2018
7953677
Merge remote-tracking branch 'origin/gitlab' into nwm-test
nwmac Nov 23, 2018
2d2757c
Git Repo autocomplete
nwmac Nov 23, 2018
fd332dd
Merge remote-tracking branch 'origin/v2-master' into git-repo-autocom…
nwmac Jan 24, 2019
669af37
Autocomplete
nwmac Jan 24, 2019
273c99a
Fix getMatchingRepositories typo
nwmac Jan 24, 2019
7ee00e3
Merge remote-tracking branch 'origin/v2-master' into autocomplete-git…
nwmac Feb 13, 2019
8b73103
Address PR Feedback
nwmac Feb 13, 2019
f4a571a
Front-end unit test fixes for switch to http client
nwmac Feb 14, 2019
d252631
Fix issue where autocomplete stops working
nwmac Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix getMatchingRepositories typo
  • Loading branch information
@nwmac
nwmac committed Jan 24, 2019
commit 273c99aa3380d34b5434bf42a162a37a328e0ed3
2 changes: 1 addition & 1 deletion ...cations/deploy-application/deploy-application-step2/deploy-application-step2.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export class DeployApplicationStep2Component

return observableTimer(500).pipe(
take(1),
switchMap(() => this.scm.getMacthingRepositories(name)),
switchMap(() => this.scm.getMatchingRepositories(name)),
tap(suggestions => this.cachedSuggestions[cacheName] = suggestions)
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/app/shared/data-services/scm/github-scm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export class GitHubSCM implements GitSCM {
return `https://github.com/${projectName}/compare/${commitSha1}...${commitSha2}`;
}

getMacthingRepositories(projectName: string): Observable<string[]> {
getMatchingRepositories(projectName: string): Observable<string[]> {
const prjParts = projectName.split('/');
let url = `${this.gitHubURL}/search/repositories?q=${projectName}+in:name`;
if (prjParts.length > 1) {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/app/shared/data-services/scm/gitlab-scm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class GitLabSCM implements GitSCM {
return `https://gitlab.com/${projectName}/compare/${commitSha1}...${commitSha2}`;
}

getMacthingRepositories(projectName: string): Observable<string[]> {
getMatchingRepositories(projectName: string): Observable<string[]> {
const prjParts = projectName.split('/');
let url = `${gitLabAPIUrl}/projects?search=${projectName}`;
if (prjParts.length > 1) {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/app/shared/data-services/scm/scm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ export interface GitSCM {
getCloneURL(projectName: string): string;
getCommitURL(projectName: string, commitSha: string): string;
getCompareCommitURL(projectName: string, commitSha1: string, commitSha2: string): string;
getMacthingRepositories(projectName: string): Observable<string[]>;
getMatchingRepositories(projectName: string): Observable<string[]>;
}