-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use side nav instead of top tabs throughout Stratos. #3289
Conversation
* v2-master: Fix test failure on faster system Remove empty rule Address review feedback Delete secrets.yaml.sys Fix e2e tests Tidy up a tad WIP Resolve conflicts. Fit in with customization Hide app vars tab if user is not a space developer Lint fix & column rename Show app chip list for space routes list bound apps - As per space service instance list - Contributes to #2610 Update side-nave logo with light version
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
This is looking great, keep going! |
It still seems strange to have "Cloud Foundry" as a top-level navigation item, but I'm not sure what to do about that... I recognize that in places where Stratos connects to multiple deployments they might each have a name that is meaningful in top-level nav, but it feels funny like this. |
* v2-master: (27 commits) Update status_updates.md Unit test fixes Added focus to first steps, ensure forms are common width Removed second entity.entity.entity check Fix weird search/replace issue Merge upstream changes properly Fix cancel on redeploy, removed some more github specific naming Fix & optimise e2e test Address PR Feedback wip General improvements - Fixed appFocus directive - Set focus of confirm dialog to cancel instead of confirm - Add/Edit App name - Add more space between async name taken check spinner and input field - Tidied up imports - Removed unused `AppEventDetailDialogComponentComponent`. Looks like a bad merge remnent - Fixed `newNonnAngularInterval` typo Ensure we don't try to get length of undefined endpoint description Remove global manage apps link - also removed the now defunct select users first step Fix e2e test Fix e2e test E2E Fix Fix e2e tests Fix e2e tests for GitLab changes Unit test fixes Fix unit tests ...
Codecov Report
@@ Coverage Diff @@
## v2-master #3289 +/- ##
=============================================
- Coverage 25.95% 25.94% -0.01%
=============================================
Files 682 682
Lines 18711 18717 +6
Branches 3258 3258
=============================================
+ Hits 4856 4857 +1
- Misses 13855 13860 +5 |
* v2-master: (415 commits) CC Fix CC Fixed and copy change Update fetch all users max pagination Merge fixes Minor text change Small text change Minor change to the invite table header Update invite users text Update the docs guide Update docs Fix unit test Fix imports Publish release pipeline fix (#3404) Re-instate setup mode Weekly update Ensure we don't add invalid state when reseting pagination Add create-many-users script Automated test script improvements and fixes (#3402) Fixed date --> data typo Remove TODOs for now ...
* v2-master: (130 commits) docs update Fix unit test Fix issues from review - Ensure extensions/extension-types.ts remains free from other imports - Now check endpoint detail type is correct at runtime - Cf Endpoint Type is now registered in cf package - Ensure cf package tests & lint execute correctly - Ensure endpoint details components are destroyed correctly Fix merge issue Fix merge issue More info Fix lint issues Add note Fix missing .entity Priorities & tweaks Remove index.html file Add support for endpoint sub type (and metadata) (#3423) Fix service broker action - Ensure that the guid property is properly set - This means error handling happens correcty Update cf-api-v3.md Updaes Another lint fix Fix linting, don't show image if no image Disable endpoint card routerLink using new directive Missing images Fix existing getIconButton bug - There may be other places where this magically worked and now correctly won't ...
This is part of the work to improve page structure within stratos.
Most of this work is inspired by how Google app engine cope with lots of data and lots of potential actions.
None of the work is final, I've not moved all of the actions from the header for example, but I would like some feedback before putting more effort moving the application in this direction. @troytop @mogul
See #3250 for a little more context and see below for some screenshots.