Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: Handle large number of apps in cf dashboards #3212

Merged
merged 26 commits into from
Jan 9, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6600168
Scalability: Applications in `Cloud Foundry` sections
richard-cox Nov 13, 2018
be40887
Fix unit tests
richard-cox Nov 15, 2018
45a42e9
Merge remote-tracking branch 'origin/v2-master' into scale-latest-apps
richard-cox Nov 19, 2018
e513482
Add custom loading text
richard-cox Nov 19, 2018
f3d3b82
Fix cf org list org card & org space list space card(!)
richard-cox Nov 20, 2018
82720a6
Merge remote-tracking branch 'origin/v2-master' into scale-latest-apps
richard-cox Nov 21, 2018
2a687cc
Fix handling of initial q params (initial q param added to store q pa…
richard-cox Nov 21, 2018
ee6b56f
Test fixes
richard-cox Nov 21, 2018
cf6c882
Fix unit test
richard-cox Nov 21, 2018
99cc501
Merge branch 'scale-app-wall' into scale-latest-apps
richard-cox Dec 3, 2018
7063793
Merge remote-tracking branch 'origin/scale-app-wall' into scale-lates…
richard-cox Dec 6, 2018
5a023f9
Merge remote-tracking branch 'origin/scale-app-wall' into scale-lates…
richard-cox Dec 13, 2018
48474e7
Merge remote-tracking branch 'origin/v2-master' into scale-latest-apps
richard-cox Dec 13, 2018
919aca6
Fix multiple apps calls
richard-cox Jan 2, 2019
09b51a8
Ensure we don't fetch app stats when maxed state
richard-cox Jan 2, 2019
6d06d30
Show full loading indicator when we're fetching maxed result pages
richard-cox Jan 2, 2019
7b01e47
Don't reset pagination when changing org/space
richard-cox Jan 2, 2019
661c1f2
Skip local filtering whilst maxed (data source specific setting and i…
richard-cox Jan 3, 2019
7ed1414
Stop blip of loading indicator when recent apps shown
richard-cox Jan 3, 2019
526fdfd
Fix nav away and return to maxed list
richard-cox Jan 3, 2019
bb9aa98
Check for `errorResponse` property rather than value in error response
richard-cox Jan 3, 2019
71b0a9f
Merge remote-tracking branch 'origin/scale-app-wall' into scale-lates…
richard-cox Jan 4, 2019
abf5475
Merge remote-tracking branch 'origin/v2-master' into scale-latest-apps
richard-cox Jan 8, 2019
3a070e1
Tidy ups
richard-cox Jan 8, 2019
ff056ec
Don't fetch space apps in space list (We get the count another way now)
richard-cox Jan 8, 2019
ccaabed
Reduce size of loading indicator overlap
richard-cox Jan 8, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit tests
  • Loading branch information
richard-cox committed Nov 15, 2018
commit be408879218455cb1a791e40f4477c6832a14be4
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { of as observableOf } from 'rxjs';

import { ActiveRouteCfOrgSpace } from '../../../../features/cloud-foundry/cf-page.types';
import { CloudFoundryEndpointService } from '../../../../features/cloud-foundry/services/cloud-foundry-endpoint.service';
import { BaseTestModulesNoShared } from '../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { CfUserService } from '../../../data-services/cf-user.service';
import { EntityMonitorFactory } from '../../../monitors/entity-monitor.factory.service';
import { PaginationMonitorFactory } from '../../../monitors/pagination-monitor.factory';
import {
ApplicationStateIconComponent,
} from '../../application-state/application-state-icon/application-state-icon.component';
import { ApplicationStateIconPipe } from '../../application-state/application-state-icon/application-state-icon.pipe';
import { StatefulIconComponent } from '../../stateful-icon/stateful-icon.component';
import { CardCfRecentAppsComponent } from './card-cf-recent-apps.component';
import { CompactAppCardComponent } from './compact-app-card/compact-app-card.component';
import { CloudFoundryEndpointService } from '../../../../features/cloud-foundry/services/cloud-foundry-endpoint.service';
import { ActiveRouteCfOrgSpace } from '../../../../features/cloud-foundry/cf-page.types';
import { EntityMonitorFactory } from '../../../monitors/entity-monitor.factory.service';
import { CfUserService } from '../../../data-services/cf-user.service';
import { PaginationMonitorFactory } from '../../../monitors/pagination-monitor.factory';
import { StatefulIconComponent } from '../../stateful-icon/stateful-icon.component';

describe('CardCfRecentAppsComponent', () => {
let component: CardCfRecentAppsComponent;
Expand Down Expand Up @@ -42,6 +43,8 @@ describe('CardCfRecentAppsComponent', () => {
beforeEach(() => {
fixture = TestBed.createComponent(CardCfRecentAppsComponent);
component = fixture.componentInstance;
component.allApps$ = observableOf([]);

fixture.detectChanges();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ export class CloudFoundryOrganizationServiceMock {
});
allOrgUsersAction = new GetAllOrgUsers('guid', 'guid-key', 'guid', true);
allOrgUsers = {};
apps$ = observableOf([]);
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,5 @@ export class CloudFoundrySpaceServiceMock {
});
allSpaceUsers = {};
allowSsh$ = observableOf('false');
apps$ = observableOf([]);
}