Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: Change application list in service instance table row from vertical to chip list #2915

Merged
merged 5 commits into from
Sep 11, 2018
Merged

Scalability: Change application list in service instance table row from vertical to chip list #2915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
beb378c
WIP
richard-cox Aug 24, 2018
753fa4f
Final tweaks
richard-cox Aug 28, 2018
1a8c382
Fix unit test [e2e]
richard-cox Aug 31, 2018
685fe79
Merge remote-tracking branch 'origin/v2-master' into bound-apps-chip-…
richard-cox Sep 3, 2018
be2dea3
Fix unit test failure
richard-cox Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix unit test failure
  • Loading branch information
@richard-cox
richard-cox committed Sep 3, 2018
commit be2dea38119357a1508caad45f63ee4b1f63737c
3 changes: 2 additions & 1 deletion ...ce-routes/table-cell-route-apps-attached/table-cell-route-apps-attached.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';

import { CloudFoundrySpaceService } from '../../../../../../features/cloud-foundry/services/cloud-foundry-space.service';
import { BaseTestModulesNoShared } from '../../../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { CloudFoundrySpaceServiceMock } from '../../../../../../test-framework/cloud-foundry-space.service.mock';
import { TableCellRouteAppsAttachedComponent } from './table-cell-route-apps-attached.component';
import { CloudFoundrySpaceService } from '../../../../../../features/cloud-foundry/services/cloud-foundry-space.service';

describe('TableCellRouteAppsAttachedComponent', () => {
let component: TableCellRouteAppsAttachedComponent;
let fixture: ComponentFixture<TableCellRouteAppsAttachedComponent>;
Expand Down
15 changes: 12 additions & 3 deletions ...ervice-instance-apps-attached/table-cell-service-instance-apps-attached.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ describe('TableCellServiceInstanceAppsAttachedComponent', () => {
beforeEach(() => {
fixture = TestBed.createComponent(TableCellServiceInstanceAppsAttachedComponent);
component = fixture.componentInstance;
component.config = {
breadcrumbs: ''
};
component.row = {
entity: {
service_plan_guid: 'service_plan',
Expand All @@ -28,16 +31,22 @@ describe('TableCellServiceInstanceAppsAttachedComponent', () => {
service_guid: 'service_guid',
service_plan_url: 'service_plan_url',
service_bindings_url: 'service_bindings_url',
service_bindings: [],
service_keys_url: 'service_keys_url',
routes_url: 'routes_url',
service_url: 'service_url',
},
metadata: null
metadata: {
created_at: '',
guid: '',
updated_at: '',
url: ''
}
};
fixture.detectChanges();
});

it('should create', () => {
it('should create', async(() => {
expect(component).toBeTruthy();
});
}));
});
19 changes: 12 additions & 7 deletions ...ances/table-cell-service-instance-tags/table-cell-service-instance-tags.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';

import { TableCellServiceInstanceTagsComponent } from './table-cell-service-instance-tags.component';
import { BaseTestModulesNoShared } from '../../../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { AppChipsComponent } from '../../../../chips/chips.component';
import { EntityMonitorFactory } from '../../../../../monitors/entity-monitor.factory.service';
import { AppChipsComponent } from '../../../../chips/chips.component';
import { TableCellServiceInstanceTagsComponent } from './table-cell-service-instance-tags.component';

describe('TableCellServiceInstanceTagsComponent', () => {
let component: TableCellServiceInstanceTagsComponent<any>;
Expand All @@ -19,7 +19,7 @@ describe('TableCellServiceInstanceTagsComponent', () => {
.compileComponents();
}));

beforeEach(() => {
beforeEach(async(() => {
fixture = TestBed.createComponent(TableCellServiceInstanceTagsComponent);
component = fixture.componentInstance;
component.row = {
Expand All @@ -41,12 +41,17 @@ describe('TableCellServiceInstanceTagsComponent', () => {
}
}
},
metadata: null
metadata: {
created_at: '',
guid: '',
updated_at: '',
url: ''
}
};
fixture.detectChanges();
});
}));

it('should create', () => {
it('should create', async(() => {
expect(component).toBeTruthy();
});
}));
});
2 changes: 1 addition & 1 deletion ...paces-service-instances/table-cell-service-name/table-cell-service-name.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';

import { TableCellServiceNameComponent } from './table-cell-service-name.component';
import { BaseTestModulesNoShared } from '../../../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { EntityMonitorFactory } from '../../../../../monitors/entity-monitor.factory.service';
import { TableCellServiceNameComponent } from './table-cell-service-name.component';

describe('TableCellServiceNameComponent', () => {
let component: TableCellServiceNameComponent<any>;
Expand Down
5 changes: 3 additions & 2 deletions ...omponents/list/list-types/service-instances/service-instances-list-config.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import { DatePipe } from '@angular/common';
import { inject, TestBed } from '@angular/core/testing';

import { ServicesService } from '../../../../../features/service-catalog/services.service';
import { ServicesServiceMock } from '../../../../../features/service-catalog/services.service.mock';
import { BaseTestModules } from '../../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { createBasicStoreModule } from '../../../../../test-framework/store-test-helper';
import { ServiceInstancesListConfigService } from './service-instances-list-config.service';
import { BaseTestModules } from '../../../../../test-framework/cloud-foundry-endpoint-service.helper';
import { ServicesServiceMock } from '../../../../../features/service-catalog/services.service.mock';

describe('ServiceInstancesListConfigService', () => {
beforeEach(() => {
TestBed.configureTestingModule({
Expand Down