E2E: Basic list component tests using organisation spaces tab #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2835 +/- ##
=============================================
- Coverage 71.34% 71.34% -0.01%
=============================================
Files 604 604
Lines 25868 25867 -1
Branches 5861 5861
=============================================
- Hits 18455 18454 -1
Misses 7413 7413 |
- Increase minimum timeout to execute any before,after,it - Reduce time taken to create test spaces - Reduce time taken to delete test spaces
- Previously failed to delete.. and then failed to connect to endpoint in next e2e test
richard-cox
changed the title
nwmac
reviewed
Aug 29, 2018
src/test-e2e/e2e.types.ts
Outdated
| @@ -1,11 +1,13 @@ | |||
| export interface E2ECred { | |||
| username: string; | |||
| password: string; | |||
| guid?: string; | |||
There was a problem hiding this comment.
Can we store this somewhere else? We're cacheing a user guid - its not part of the credential.
src/test-e2e/e2e.types.ts
Outdated
| } | ||
|
|
||
| export interface E2ECreds { | ||
| admin: E2ECred; | ||
| nonAdmin?: E2ECred; | ||
| guid: string; |
For request params ensure xGUID -> xGuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.