Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we don't recursively delete with the action is an update #2620

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Ensure we don't recursively delete with the action is an update #2620

merged 3 commits into from
Jul 4, 2018

Conversation

KlapTrap
Copy link
Contributor

@KlapTrap KlapTrap commented Jul 3, 2018 •
edited by irfanhabib
Loading

Fixes #2608
Fixes #2623

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 4, 2018 •
edited
Loading

Codecov Report

Merging #2620 into v2-master will decrease coverage by 0.04%.
The diff coverage is 45.28%.

@@              Coverage Diff              @@
##           v2-master    #2620      +/-   ##
=============================================
- Coverage      69.97%   69.92%   -0.05%     
=============================================
  Files            595      596       +1     
  Lines          25235    25289      +54     
  Branches        5700     5716      +16     
=============================================
+ Hits           17657    17684      +27     
- Misses          7578     7605      +27

irfanhabib
irfanhabib suggested changes Jul 4, 2018
View reviewed changes
src/frontend/app/store/effects/api.effects.ts Outdated
@@ -508,5 +508,8 @@ export class APIEffect {
}
}
}
private shouldRecusivlyDelete(requestType: string, apiAction: ICFAction) {
return requestType === 'delete' && !apiAction.updatingKey;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name has a typo.. should be shouldRecursivelyDelete

@irfanhabib irfanhabib mentioned this pull request Jul 4, 2018
Merged
@irfanhabib
Copy link
Contributor

LGTM

@irfanhabib irfanhabib merged commit c4ab149 into v2-master Jul 4, 2018
@irfanhabib irfanhabib deleted the permission-delete-recursive-bug branch July 4, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfanhabib irfanhabib irfanhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KlapTrap @cfdreddbot @irfanhabib