[RFC0030 - 3] File-based service bindings #4026
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
force-pushed
the
file-based-service-bindings
branch
from
26e6766 to
133a686
Compare
philippthun
force-pushed
the
file-based-service-bindings
branch
2 times, most recently
from
f0a3ac6 to
4879337
Compare
philippthun
changed the title
philippthun
force-pushed
the
file-based-service-bindings
branch
from
4879337 to
3592e9b
Compare
philippthun
force-pushed
the
file-based-service-bindings
branch
2 times, most recently
from
d32cce4 to
15a8a9c
Compare
philippthun
force-pushed
the
file-based-service-bindings
branch
2 times, most recently
from
5031bdb to
7501f93
Compare
When the app feature 'file-based service bindings' is enabled,
SERVICE_BINDING_ROOT is returned instead of VCAP_SERVICES.
For an app using file-based service bindings the '/env' endpoint (i.e.
GET /v3/apps/:guid/env) returns the following:
{
...
"system_env_json": {
"SERVICE_BINDING_ROOT": "/etc/cf-service-bindings"
},
...
}
The file runtime_environment/system_env_presenter_spec.rb has been
deleted because all the tests it contained are also present in
system_environment/system_env_presenter_spec.rb.
- validate binding names and (credential) keys - check for duplicate binding names - check the total bytesize, maximum allowed size is 1MB - files are added in the following order: 1. credential keys 2. VCAP_SERVICES attributes 3. 'type' and 'provider' - in case a credential key equals a VCAP_SERVICES attributes or 'type' or 'provider', it will be overwritten - for VCAP_SERVICES attribute names, underscores are replaced by hyphens - file content is serialized as JSON (non-string objects)
- AppRecipeBuilder -> Diego::Bbs::Models::DesiredLRP - TaskRecipeBuilder -> Diego::Bbs::Models::TaskDefinition
philippthun
force-pushed
the
file-based-service-bindings
branch
from
7501f93 to
763edab
Compare
jochenehret
reviewed
Dec 12, 2024
| @service_bindings.select(&:create_succeeded?).each do |service_binding| | ||
| sb_hash = ServiceBindingPresenter.new(service_binding, include_instance: true).to_hash | ||
| name = sb_hash[:name] | ||
| raise IncompatibleBindings.new("Invalid binding name: #{name}") unless valid_name?(name) |
There was a problem hiding this comment.
Can you explain in the error message which names are valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests