Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Workers Memory Limits docs #19049

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

Rewrite Workers Memory Limits docs #19049

wants to merge 3 commits into from

Conversation

irvinebroque
Copy link
Contributor

Fielded a question and think these docs could be clearer, took a pass

@irvinebroque irvinebroque requested review from GregBrimble and a team as code owners January 7, 2025 15:46
@github-actions github-actions bot added product:workers Related to Workers product size/s labels Jan 7, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 317e00a
Status: ✅  Deploy successful!
Preview URL: https://b0837bbc.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://bib-memory-limits.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/platform/limits/ https://bib-memory-limits.cloudflare-docs-7ou.pages.dev/workers/platform/limits/

@irvinebroque @southpolesteve
Update src/content/docs/workers/platform/limits.mdx
59b8519 
Co-authored-by: Steve Faulkner <southpolesteve@gmail.com>
mikenomitch
mikenomitch approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mikenomitch mikenomitch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Added a couple minor suggestions but not blockers

@irvinebroque irvinebroque enabled auto-merge (squash) January 8, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlapid danlapid danlapid approved these changes

@kentonv kentonv kentonv approved these changes

@mikenomitch mikenomitch mikenomitch approved these changes

@southpolesteve southpolesteve southpolesteve approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GregBrimble GregBrimble

Labels
product:workers Related to Workers product size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@irvinebroque @southpolesteve @mikenomitch @kentonv @danlapid @GregBrimble